-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Test: Replace deprecated checkContractWalletSignature use #4949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4949 +/- ##
==========================================
+ Coverage 47.60% 47.62% +0.02%
==========================================
Files 1058 1057 -1
Lines 57299 57261 -38
Branches 3929 3930 +1
==========================================
- Hits 27276 27271 -5
+ Misses 29334 29301 -33
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on updating the function used to verify wallet signatures in the `smart-wallet-integration.test.ts` file. The change improves clarity by renaming `checkContractWalletSignature` to `verifySignature` and modifies the way the contract is obtained.
### Detailed summary
- Renamed the function from `checkContractWalletSignature` to `verifySignature`.
- Changed the way the contract is constructed by removing the `getContract` call and directly using the parameters `address`, `chain`, and `client`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
ab0c597 to
89bcb92
Compare
PR-Codex overview
This PR focuses on renaming a function and restructuring the parameters passed to it in the test file for the
smart-wallet-integration. The changes enhance clarity and maintainability of the code.Detailed summary
checkContractWalletSignaturetoverifySignature.verifySignatureby directly usingaddress,chain, andclientinstead of wrapping them ingetContract.