feat: Support multiple wallets in Engine dashboard #4956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arcoraven
commented
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4956 +/- ##
=======================================
Coverage 47.77% 47.77%
=======================================
Files 1058 1058
Lines 57276 57276
Branches 3947 3947
=======================================
Hits 27362 27362
Misses 29223 29223
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
arcoraven
force-pushed
the
ph/engineWallets
branch
from
18c73c4 to
4288ee0
Compare
MananTank
reviewed
Oct 9, 2024
MananTank
reviewed
Oct 9, 2024
apps/dashboard/src/components/engine/overview/import-backend-wallet-button.tsx
Outdated
Show resolved
Hide resolved
MananTank
approved these changes
Oct 14, 2024
Contributor
Author
Merge activity
|
- Adds support for configuring creds for AWS + GCP independently
- Moves all touched UI to tailwind
- Import / Create wallet buttons allow selecting the wallet type
- Unrelated: Moved version upgrade button to the new enpdoint. Will deprecate the old one.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on refactoring the engine configuration components to improve how instances and wallet configurations are handled, enhancing the overall clarity and functionality of the engine's wallet management features.
### Detailed summary
- Removed `instanceUrl` prop in favor of `instance` for components.
- Introduced `LocalConfig` component for local wallet configuration.
- Added support for multiple wallet types with `EngineBackendWalletOptions`.
- Updated wallet configuration forms to use a unified `Form` component.
- Improved error handling and user feedback for wallet operations.
- Enhanced dialog components for creating and importing backend wallets.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
arcoraven
force-pushed
the
ph/engineWallets
branch
from
4198aaa to
4672475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the handling of backend wallet configurations in the
enginemodule. It introduces new components and updates existing ones to improve the integration of local, AWS KMS, and GCP KMS wallets, along with better feature support checks.Detailed summary
instanceUrlprop in favor ofinstancefor several components.LocalConfigcomponent for local wallet setup.EngineWalletConfigto manage wallet types more efficiently.EngineBackendWalletTypeand related options.