Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 8, 2024

image.png


PR-Codex overview

This PR focuses on refactoring the network selection components in the application. It replaces the NetworkDropdown component with a new SingleNetworkSelector component across various files, enhancing the network selection functionality.

Detailed summary

  • Removed NetworkDropdown imports and usages.
  • Introduced SingleNetworkSelector in multiple components.
  • Updated props and event handling for chain selection.
  • Modified layout dimensions in the CustomFactory component.
  • Added new SelectWithSearch component for improved search functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:20pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 8, 2024 10:20pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 8, 2024 10:20pm
wallet-ui ⬜️ Skipped (Inspect) Oct 8, 2024 10:20pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 8, 2024 21:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 8, 2024 21:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 8, 2024 21:24 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 74cd019

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 8, 2024 21:24
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 8, 2024
Copy link
Member Author

MananTank commented Oct 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank changed the title Improved Single Network Selector component Add SelectWithSearch + Improved Single Network Selector component Oct 8, 2024
@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.60%. Comparing base (f5d2d35) to head (74cd019).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4957   +/-   ##
=======================================
  Coverage   47.60%   47.60%           
=======================================
  Files        1058     1058           
  Lines       57299    57299           
  Branches     3929     3929           
=======================================
  Hits        27276    27276           
  Misses      29334    29334           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f5d2d35
packages 43.36% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.1 KB (0%) 842 ms (0%) 2.2 s (+1.06% 🔺) 3 s
thirdweb (cjs) 101.73 KB (0%) 2.1 s (0%) 5.7 s (+1.43% 🔺) 7.7 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 110 ms (-57.55% 🔽) 207 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 82 ms (+4.4% 🔺) 92 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 727 ms (+28.68% 🔺) 1.1 s

@MananTank MananTank force-pushed the 10-09-improved_single_network_selector_component branch from 955a6ac to 44792af Compare October 8, 2024 21:32
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 8, 2024 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 8, 2024 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 8, 2024 21:32 Inactive
@MananTank MananTank changed the base branch from 10-09-improved_multi_network_selector_component to graphite-base/4957 October 8, 2024 21:33
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 8, 2024

Merge activity

@jnsdls jnsdls changed the base branch from graphite-base/4957 to main October 8, 2024 21:44
@MananTank MananTank force-pushed the 10-09-improved_single_network_selector_component branch from 44792af to c148d1a Compare October 8, 2024 21:52
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 8, 2024 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 8, 2024 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 8, 2024 21:52 Inactive
)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/yNOf1svJ8o3zjO7zQouZ/4586e4df-ba4e-4d02-b594-61c61c81f446.png)

<!-- start pr-codex -->

---

## PR-Codex overview
This PR refactors the network selection components by replacing `NetworkDropdown` with `SingleNetworkSelector` across multiple files, enhancing the network selection UI and functionality.

### Detailed summary
- Removed `NetworkDropdown` from various components.
- Introduced `SingleNetworkSelector` to replace `NetworkDropdown`.
- Updated props for `SingleNetworkSelector` to improve chain selection.
- Refactored related imports to point to the new component location.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-09-improved_single_network_selector_component branch from c148d1a to 74cd019 Compare October 8, 2024 22:11
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 8, 2024 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 8, 2024 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 8, 2024 22:11 Inactive
@graphite-app graphite-app bot merged commit 74cd019 into main Oct 8, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-09-improved_single_network_selector_component branch October 8, 2024 22:21
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 8, 2024 22:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 8, 2024 22:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 8, 2024 22:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants