Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on improving the layout and readability of the SponsorshipPolicies component in the AccountAbstractionSettingsPage. It enhances the spacing and formatting of text elements.

Detailed summary

  • Added gap-6 lg:gap-12 to several div elements for improved spacing.
  • Replaced line breaks with <br /> tags in Text components for better text formatting.
  • Adjusted text descriptions for clarity and readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:09pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 9, 2024 6:09pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 9, 2024 6:09pm
wallet-ui ⬜️ Skipped (Inspect) Oct 9, 2024 6:09pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 17:57 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: e29d80a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 17:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 17:57 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 9, 2024 17:57
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 9, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.66%. Comparing base (0c5b0bf) to head (e29d80a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4973   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files        1057     1057           
  Lines       57267    57267           
  Branches     3939     3939           
=======================================
  Hits        27299    27299           
  Misses      29277    29277           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0c5b0bf
packages 43.44% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.1 KB (0%) 842 ms (0%) 2.5 s (+31.87% 🔺) 3.4 s
thirdweb (cjs) 101.73 KB (0%) 2.1 s (0%) 7.1 s (+36.93% 🔺) 9.2 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 181 ms (+46.27% 🔺) 278 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 44 ms (-10.94% 🔽) 54 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 671 ms (+71.66% 🔺) 1.1 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the layout and readability of the `SponsorshipPolicies` component in the `AccountAbstractionSettingsPage` by adjusting the spacing in flex containers and modifying text formatting for better clarity.

### Detailed summary
- Updated `div` elements to include `gap-6 lg:gap-12` for improved spacing.
- Changed text formatting to use `<br />` for line breaks instead of plain text.
- Made similar adjustments across multiple sections, including global spend limits and restrict to specific chains.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-09-spacing_adjustments_on_account-abstraction_policies_form branch from 5fc35b8 to e29d80a Compare October 9, 2024 18:06
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 18:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 18:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 18:06 Inactive
@graphite-app graphite-app bot merged commit e29d80a into main Oct 9, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-09-spacing_adjustments_on_account-abstraction_policies_form branch October 9, 2024 18:10
@vercel vercel bot temporarily deployed to Production – wallet-ui October 9, 2024 18:10 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 9, 2024 18:10 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 9, 2024 18:10 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants