Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 10, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating icon imports in various components to use lucide-react icons instead of react-icons. It enhances the UI by ensuring consistent icon usage across the application.

Detailed summary

  • Replaced BsLightning with ZapIcon in HomePageCodeBlock.
  • Replaced FiHelpCircle with InfoIcon in CustomContractForm.
  • Replaced FiGlobe with GlobeIcon in PublisherSocials.
  • Replaced FiCopy with CopyIcon and FiChevronDown with ChevronDownIcon in EventsFeedItem.
  • Replaced FiUpload and FiImage with UploadIcon and ImageIcon respectively in FileInput.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 3:00pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 10, 2024 3:00pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 10, 2024 3:00pm
wallet-ui ⬜️ Skipped (Inspect) Oct 10, 2024 3:00pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: c776943

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 10, 2024 00:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 10, 2024 00:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 10, 2024 00:55 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review October 10, 2024 00:55
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 10, 2024
Copy link
Contributor Author

kien-ngo commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.74%. Comparing base (abcbcd0) to head (c776943).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4980   +/-   ##
=======================================
  Coverage   47.74%   47.74%           
=======================================
  Files        1059     1059           
  Lines       57328    57328           
  Branches     3944     3944           
=======================================
  Hits        27369    27369           
  Misses      29268    29268           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from abcbcd0
packages 43.53% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 247 ms (+24.7% 🔺) 1.1 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 384 ms (-21.94% 🔽) 2.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 11 ms (-6.64% 🔽) 108 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 6 ms (+71.43% 🔺) 16 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 43 ms (-0.16% 🔽) 388 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 10, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating icon imports in various components, replacing some icons from `react-icons` with corresponding icons from `lucide-react`, and modifying the icon usage in the `HomePageCodeBlock`, `CustomContractForm`, `PublisherSocials`, `EventsFeedItem`, and `FileInput` components.

### Detailed summary
- Replaced `BsLightning` with `ZapIcon` in `HomePageCodeBlock`.
- Replaced `FiHelpCircle` with `InfoIcon` in `CustomContractForm`.
- Replaced `FiGlobe` with `GlobeIcon` in `PublisherSocials`.
- Replaced `FiCopy` with `CopyIcon` and `FiChevronDown` with `ChevronDownIcon` in `EventsFeedItem`.
- Replaced `FiUpload` with `UploadIcon` and `FiImage` with `ImageIcon` in `FileInput`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/remove-react-icons-1 branch from d786d40 to c776943 Compare October 10, 2024 14:50
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 10, 2024 14:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 10, 2024 14:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 10, 2024 14:51 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 10, 2024 15:00 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 10, 2024 15:00 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 10, 2024 15:00 Inactive
@graphite-app graphite-app bot merged commit c776943 into main Oct 10, 2024
31 of 33 checks passed
@graphite-app graphite-app bot deleted the kien/remove-react-icons-1 branch October 10, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants