Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 11, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the dashboard and contract management features by improving layout components, adding new functionalities for contract handling, and refining the UI components for better user experience.

Detailed summary

  • Updated layout in deploy.tsx and layout.tsx to use flexbox.
  • Introduced getAuthTokenWalletAddress function for account management.
  • Created DeployedContractsPage and DeployedContractsTable components.
  • Enhanced GetStartedWithContractsDeploy with wallet connection logic.
  • Refactored DeployedContracts to accept contractList and isPending props.
  • Added loading states and improved user feedback in contract tables.
  • Integrated ImportModal and button functionalities for contract management.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 9:28pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 14, 2024 9:28pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 14, 2024 9:28pm
wallet-ui ⬜️ Skipped (Inspect) Oct 14, 2024 9:28pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 18:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 18:04 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 92fbb18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 18:04 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 11, 2024
@MananTank MananTank marked this pull request as ready for review October 11, 2024 18:05
Copy link
Member Author

MananTank commented Oct 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from 7b82b42 to 76ecba5 Compare October 11, 2024 18:06
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 18:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 18:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 18:07 Inactive
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from 76ecba5 to be8d45f Compare October 11, 2024 18:08
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 18:08 Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.77%. Comparing base (6ceb24b) to head (92fbb18).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4995   +/-   ##
=======================================
  Coverage   47.77%   47.77%           
=======================================
  Files        1058     1058           
  Lines       57276    57276           
  Branches     3946     3946           
=======================================
  Hits        27362    27362           
  Misses      29223    29223           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6ceb24b
packages 43.57% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 288 ms (+15.66% 🔺) 1.2 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 448 ms (-7.98% 🔽) 2.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 33 ms (+5.04% 🔺) 130 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 129 ms (+1372.96% 🔺) 139 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 300 ms (+448.86% 🔺) 645 ms

@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from be8d45f to a4ee55c Compare October 11, 2024 18:14
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 18:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 18:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 18:14 Inactive
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from a4ee55c to 2d4f96c Compare October 11, 2024 18:36
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 18:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 18:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 18:19 Inactive
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from be1b851 to bcf1624 Compare October 14, 2024 19:13
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 19:13 Inactive
@MananTank MananTank requested a review from jnsdls October 14, 2024 19:31
Copy link
Member Author

@jnsdls Wrapped the contracts that fetches the contracts with suspense - you should see the shell of the page instantly now

@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from bcf1624 to 4b31754 Compare October 14, 2024 20:15
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 20:15 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 14, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the contract deployment and management features in the dashboard application. It introduces new components, improves layouts, and refines data handling for better user experience.

### Detailed summary
- Updated layout in `deploy.tsx` and `layout.tsx` to use flexbox for better responsiveness.
- Added `getAuthTokenWalletAddress` function in `getAuthToken.ts` for wallet address retrieval.
- Introduced `DeployedContractsPage` and `DeployedContractsTable` components for contract management.
- Refactored `DeployedContracts` component to accept contract list directly and handle loading state.
- Added `GetStartedWithContractsDeploy` component for user onboarding.
- Enhanced `DeployedContractsPageHeader` with import and deploy contract buttons.
- Improved sorting logic in `getSortedDeployedContracts.tsx`.
- Removed unused imports and cleaned up code for better readability.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from 4b31754 to 92fbb18 Compare October 14, 2024 20:53
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 20:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 20:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 20:53 Inactive
@graphite-app graphite-app bot merged commit 92fbb18 into main Oct 14, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-11-move_deployed_contracts_page_to_app_router branch October 14, 2024 21:28
@vercel vercel bot temporarily deployed to Production – wallet-ui October 14, 2024 21:28 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 14, 2024 21:28 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 14, 2024 21:28 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 14, 2024 21:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants