-
Notifications
You must be signed in to change notification settings - Fork 619
Migrate Marketplace Listing Stats on Contract Overview page to shadcn+tailwind #5040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Marketplace Listing Stats on Contract Overview page to shadcn+tailwind #5040
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5040 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1059 1059
Lines 54707 54707
Branches 3954 3954
=======================================
Hits 24786 24786
Misses 29230 29230
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Merge activity
|
…+tailwind (#5040) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on refactoring components in the `MarketplaceDetails.tsx` and `listing-stats.tsx` files to replace instances of the `Flex` component with standard `div` elements, while also introducing a new `StatCard` component for displaying statistics. ### Detailed summary - Replaced `Flex` components with `div` elements in `DirectListingCards`, `EnglishAuctionCards`, and `MarketplaceDetails`. - Introduced a new `StatCard` component in `listing-stats.tsx` for displaying statistics. - Updated the rendering of total listings, direct listings, and English auctions to use `StatCard`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
a51607e to
0cf478e
Compare
0391411 to
ccff347
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the
MarketplaceDetailsandListingStatscomponents by replacingFlexcomponents with standarddivelements for layout, and it introduces a newStatCardcomponent to streamline the display of statistics.Detailed summary
Flexcomponents withdivelements inDirectListingCards,EnglishAuctionCards, andMarketplaceDetails.StatCardcomponent to display stats inListingStatsV3.StatCard.