Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 18, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates descriptions in two files to include Unreal Engine alongside existing platforms, enhancing clarity regarding the supported environments for social logins and smart contract integration.

Detailed summary

  • In apps/dashboard/src/components/embedded-wallets/Configure/index.tsx, Unreal Engine was added to the platforms listed for social logins.
  • In apps/dashboard/src/pages/interact.tsx, Unreal Engine was included in the description for smart contract integration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 18, 2024 5:32pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 18, 2024 5:32pm
wallet-ui ⬜️ Skipped (Inspect) Oct 18, 2024 5:32pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 17:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 17:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 17:03 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 0dbb174

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 18, 2024 17:03
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 18, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (0a1d59d) to head (0dbb174).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5082   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54729    54729           
  Branches     3956     3956           
=======================================
  Hits        24791    24791           
  Misses      29247    29247           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0a1d59d
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 638 ms (-14.44% 🔽) 1.5 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 1.6 s (+10.57% 🔺) 3.7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 31 ms (-66.57% 🔽) 127 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 27 ms (-41.16% 🔽) 37 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 233 ms (+134.26% 🔺) 580 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 18, 2024

Merge activity

MananTank added a commit that referenced this pull request Oct 18, 2024
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the descriptions in the `Configure` component and the `interact.tsx` page to include `Unreal Engine` as a supported platform alongside `Unity` and `React Native` for social logins and smart contract integration.

### Detailed summary
- In `apps/dashboard/src/components/embedded-wallets/Configure/index.tsx`, updated the description to include `Unreal Engine` as a platform for social logins.
- In `apps/dashboard/src/pages/interact.tsx`, modified the description to include `Unreal Engine` as a supported platform for smart contracts.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-18-mention_missing_unreal_engine_in_various_copy branch from a363ed3 to 9616831 Compare October 18, 2024 17:13
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 17:13 Inactive
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the descriptions in two files to include `Unreal Engine` as a supported platform alongside `Unity` and `React Native` for social logins and smart contract integrations.

### Detailed summary
- Updated the text in `apps/dashboard/src/components/embedded-wallets/Configure/index.tsx` to include `Unreal Engine` in the supported platforms for social logins.
- Modified the `description` in `apps/dashboard/src/pages/interact.tsx` to add `Unreal Engine` as a supported platform for smart contract integrations.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-18-mention_missing_unreal_engine_in_various_copy branch from 9616831 to 0dbb174 Compare October 18, 2024 17:19
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 17:19 Inactive
@graphite-app graphite-app bot merged commit 0dbb174 into main Oct 18, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-18-mention_missing_unreal_engine_in_various_copy branch October 18, 2024 17:33
@vercel vercel bot temporarily deployed to Production – docs-v2 October 18, 2024 17:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants