Skip to content

Conversation

@kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Oct 21, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces the export of the verifyContract function and integrates it into the CustomContractForm component to facilitate contract verification after deployment.

Detailed summary

  • Changed verifyContract from a local function to an exported function in ContractSourcesPage.tsx.
  • Imported verifyContract in custom-contract.tsx.
  • Called verifyContract after deploying a contract in CustomContractForm.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: e7bbc32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:52pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:52pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Oct 21, 2024 10:52pm
wallet-ui ⬜️ Skipped (Inspect) Oct 21, 2024 10:52pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 21, 2024
@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (8f157aa) to head (e7bbc32).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5099   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54754    54754           
  Branches     3956     3956           
=======================================
  Hits        24802    24802           
  Misses      29261    29261           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8f157aa
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 4.2 s (+7.4% 🔺) 5.1 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 5.2 s (-19.22% 🔽) 7.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 224 ms (+5.66% 🔺) 321 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 119 ms (+175.61% 🔺) 129 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 477 ms (-16.87% 🔽) 824 ms

Copy link
Member Author

kumaryash90 commented Oct 21, 2024

Merge activity

  • Oct 21, 5:08 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 21, 6:10 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 6:53 PM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces the export of the `verifyContract` function from `ContractSourcesPage.tsx` and integrates it into the `CustomContractForm` component to send a verification request after deploying a contract.

### Detailed summary
- Changed `verifyContract` from a local function to an exported function in `ContractSourcesPage.tsx`.
- Imported `verifyContract` into `custom-contract.tsx`.
- Added a call to `verifyContract` in the `CustomContractForm` after contract deployment.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kumaryash90 kumaryash90 force-pushed the yash/auto-verification branch from 3facd4d to e7bbc32 Compare October 21, 2024 22:09
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 22:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 22:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 22:09 Inactive
@graphite-app graphite-app bot merged commit e7bbc32 into main Oct 21, 2024
31 checks passed
@graphite-app graphite-app bot deleted the yash/auto-verification branch October 21, 2024 22:53
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 21, 2024 22:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants