Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 22, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR refactors the test for minting additional supply to an ERC1155 batch, updating the test structure and changing the transaction method used to mint tokens.

Detailed summary

  • Changed the test description to use describe.runIf(process.env.TW_SECRET_KEY).
  • Updated the transaction method from mintToBatch to mintAdditionalSupplyToBatch.
  • Adjusted the structure of the NFT objects in the minting process.
  • Verified the expected NFT details after minting.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:40pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:40pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:40pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:40pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 5351d4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review October 22, 2024 07:21
Copy link
Contributor Author

kien-ngo commented Oct 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 3.2 s (+25.94% 🔺) 4 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 5 s (-23.09% 🔽) 7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 165 ms (+1.98% 🔺) 261 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 132 ms (-50.01% 🔽) 142 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 598 ms (-40.14% 🔽) 945 ms

@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.28%. Comparing base (0cafa33) to head (5351d4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5122      +/-   ##
==========================================
+ Coverage   45.26%   45.28%   +0.01%     
==========================================
  Files        1061     1060       -1     
  Lines       54869    54841      -28     
  Branches     3955     3957       +2     
==========================================
- Hits        24837    24835       -2     
+ Misses      29341    29315      -26     
  Partials      691      691              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0cafa33
packages 40.23% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 22, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR refactors the test for the `mintToBatch` function, changing its execution context and updating the minting logic to utilize `mintAdditionalSupplyToBatch`. It also modifies the structure of the NFT data being tested.

### Detailed summary
- Changed `describe` to use `describe.runIf(process.env.TW_SECRET_KEY)`.
- Updated minting function from `mintToBatch` to `mintAdditionalSupplyToBatch`.
- Adjusted parameters for minting NFTs.
- Modified the expected NFT details in the final assertion.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants