Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 23, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on restructuring the file paths for components related to the engine, moving them to a more organized directory structure. It also updates import paths in several files to reflect these changes.

Detailed summary

  • Moved EngineAdmins, EngineRelayer, EngineExplorer, EngineSystemMetrics, EngineAlertsPage, EngineConfiguration, EngineAccessTokens, and EngineContractSubscriptions to a new directory structure.
  • Updated import paths accordingly in multiple files.
  • Adjusted CSS imports for swagger-ui.css to the new location.
  • Refactored RecentEngineAlerts and ManageEngineAlerts stories to the new components directory.
  • Updated EngineSystemMetrics imports in the metrics component to reflect the new structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:23pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 6:23pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 6:23pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 6:23pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 20:28 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 74d113c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 20:28 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 23, 2024
@MananTank MananTank marked this pull request as ready for review October 23, 2024 20:28
Copy link
Member Author

MananTank commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (486cd4a) to head (74d113c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5145   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 486cd4a
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 2.6 s (+12.78% 🔺) 3.4 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 4.8 s (-16.98% 🔽) 6.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 161 ms (-22.25% 🔽) 258 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 43 ms (-38.95% 🔽) 53 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 446 ms (+12.89% 🔺) 793 ms

@MananTank MananTank force-pushed the 10-24-move_engine_page_components_to_app_router_folder_in_teams_layout branch from 993ccdf to 8178840 Compare October 23, 2024 21:11
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 21:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 21:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 21:11 Inactive
@MananTank MananTank force-pushed the 10-24-move_engine_page_components_to_app_router_folder_in_teams_layout branch from 8178840 to dc5585a Compare October 24, 2024 11:46
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 24, 2024 11:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 24, 2024 11:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 24, 2024 11:46 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on restructuring the file organization and import paths for various components within the dashboard application, specifically related to engine functionalities. It also includes updates to stylesheets and components for better modularity.

### Detailed summary
- Updated import paths for several components to a new directory structure.
- Refactored components like `EngineAdmins`, `EngineRelayer`, `EngineExplorer`, etc., to use relative imports from the new structure.
- Adjusted CSS imports for `swagger-ui.css` and other styles.
- Updated story files for `RecentEngineAlerts` and `ManageEngineAlerts` to reflect new paths.
- Modified `EngineSystemMetrics` component imports for better organization.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-24-move_engine_page_components_to_app_router_folder_in_teams_layout branch from dc5585a to 74d113c Compare October 28, 2024 18:12
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 18:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 18:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 18:12 Inactive
@graphite-app graphite-app bot merged commit 74d113c into main Oct 28, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 10-24-move_engine_page_components_to_app_router_folder_in_teams_layout branch October 28, 2024 18:24
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 18:24 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 18:24 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 18:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants