Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Oct 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR primarily focuses on updating various components and functions in the codebase to handle asynchronous operations more effectively, particularly regarding cookie management and parameter handling. It also includes minor adjustments to improve type safety and function signatures.

Detailed summary

  • Changed several functions to use await for cookie retrieval.
  • Updated parameter handling in multiple async functions to use Promise.
  • Adjusted type definitions for better clarity and safety.
  • Modified several components to ensure proper async behavior.
  • Enabled capture_pageview in root-providers.tsx.
  • Updated revalidate time in layout.tsx to 300 seconds.

The following files were skipped due to too many changes: apps/dashboard/src/app/team/[team_slug]/[project_slug]/engine/(instance)/[engineId]/metrics/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/account-permissions/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/claim-conditions/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/accounts/page.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/engine/(instance)/[engineId]/configuration/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/split/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/proposals/page.tsx, apps/dashboard/src/app/layout.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/account/page.tsx, apps/portal/mdx-components.tsx, apps/dashboard/src/app/api/lib/getAuthToken.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/embed/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/analytics/page.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/account-abstraction/page.tsx, apps/dashboard/src/app/(dashboard)/published-contract/page.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/engine/(instance)/[engineId]/page.tsx, apps/dashboard/src/app/(dashboard)/contracts/deploy/[compiler_uri]/page.tsx, apps/playground-web/src/app/connect/sign-in/button/page.tsx, apps/dashboard/src/app/api/contact-us/route.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/_utils/getContractFromParams.ts, apps/dashboard/src/app/api/testnet-faucet/can-claim/route.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/tx/[txHash]/page.tsx, apps/dashboard/src/components/buttons/MismatchButton.tsx, apps/wallet-ui/src/app/[ecosystem]/(authed)/wallet/[address]/layout.tsx, apps/dashboard/src/app/login/auth-actions.ts, apps/dashboard/src/app/(dashboard)/trending/page.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/in-app-wallets/layout.tsx, apps/dashboard/src/app/(dashboard)/support/create-ticket/components/create-ticket.client.tsx, apps/dashboard/src/app/(dashboard)/dashboard/connect/account-abstraction/[clientId]/page.tsx, apps/wallet-ui/package.json, apps/dashboard/src/app/team/[team_slug]/(team)/layout.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/analytics/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/layout.tsx, apps/dashboard/src/app/api/testnet-faucet/claim/route.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/(chainPage)/layout.tsx, apps/playground-web/package.json, apps/dashboard/src/app/(dashboard)/contracts/publish/[publish_uri]/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/chainlist/page.tsx, apps/dashboard/src/app/(dashboard)/published-contract/[publisher]/[contract_id]/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/page.tsx, apps/dashboard/src/app/(dashboard)/explore/[category]/page.tsx, apps/playground-web/src/app/connect/auth/server/actions/auth.ts, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/(chainPage)/popular/page.tsx, apps/portal/package.json, apps/dashboard/src/app/team/[team_slug]/[project_slug]/layout.tsx, apps/dashboard/src/app/(dashboard)/published-contract/[publisher]/[contract_id]/[version]/page.tsx, apps/portal/src/app/references/components/TDoc/PageLayout.tsx, apps/dashboard/package.json, packages/thirdweb/package.json, apps/dashboard/src/app/(dashboard)/(chain)/chainlist/[chain_type]/page.tsx, apps/portal/src/app/typescript/v5/supported-wallets/[walletId]/page.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: c3a42e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:38am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:38am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:38am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:38am

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 24, 2024 — with Graphite App
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages labels Oct 24, 2024
@jnsdls jnsdls marked this pull request as ready for review October 24, 2024 01:48
Copy link
Member Author

jnsdls commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@socket-security
Copy link

socket-security bot commented Oct 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@next/bundle-analyzer@15.0.2 Transitive: environment, filesystem, network, shell +18 2.31 MB matt.straka, rauchg, timer, ...2 more
npm/@next/eslint-plugin-next@15.0.2 Transitive: filesystem +18 587 kB matt.straka, rauchg, timer, ...2 more
npm/@next/mdx@15.0.2 Transitive: filesystem, network +1 238 kB matt.straka, rauchg, timer, ...2 more
npm/@vercel/functions@1.5.0 None 0 79.7 kB vercel-release-bot
npm/eslint-config-next@15.0.2 Transitive: environment, eval, filesystem, unsafe +164 15.3 MB timer, timneutkens, vercel-release-bot
npm/eslint-plugin-react-compiler@19.0.0-beta-8a03594-20241020 Transitive: environment, filesystem, shell +49 14.9 MB react-bot
npm/next-themes@0.4.3 None 0 33.7 kB paco
npm/next@15.0.2 environment, filesystem, network, shell, unsafe +13 122 MB vercel-release-bot
npm/react-dom@19.0.0-rc-69d4b800-20241021 environment +1 6.45 MB fb, gnoff, react-bot, ...2 more
npm/react-native@0.76.1 Transitive: environment, eval, filesystem, network, shell, unsafe +929 287 MB cortinico, eliwhite, fb, ...4 more
npm/react@19.0.0-rc-69d4b800-20241021 environment 0 239 kB react-bot
npm/types-react-dom@19.0.0-rc.1 None 0 17.7 kB eps1lon
npm/types-react@19.0.0-rc.1 None +1 1.63 MB eps1lon

🚮 Removed packages: npm/@next/bundle-analyzer@14.2.15, npm/@next/eslint-plugin-next@14.2.15, npm/@next/mdx@13.5.7, npm/@types/react-dom@18.3.1, npm/@types/react@18.3.12, npm/eslint-config-next@14.2.15, npm/eslint-plugin-react-compiler@0.0.0-experimental-fa06e2c-20241014, npm/next-themes@0.3.0, npm/next@14.2.15, npm/react-native@0.76.0

View full report↗︎

@socket-security
Copy link

socket-security bot commented Oct 24, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Possible typosquat attack npm/types-react-dom@19.0.0-rc.1 ⚠︎

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/types-react-dom@19.0.0-rc.1

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 1.1 s (+6.04% 🔺) 2 s
thirdweb (cjs) 103 KB (0%) 2.1 s (0%) 2.3 s (-4.28% 🔽) 4.4 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 70 ms (+43.34% 🔺) 167 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 33 ms (+124.52% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 17.51 KB (0%) 351 ms (0%) 235 ms (+56.21% 🔺) 585 ms

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.56%. Comparing base (0a3b59c) to head (c3a42e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...irdweb/src/react/web/wallets/in-app/WalletAuth.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5152   +/-   ##
=======================================
  Coverage   45.56%   45.56%           
=======================================
  Files        1067     1067           
  Lines       55487    55487           
  Branches     4031     4030    -1     
=======================================
  Hits        25282    25282           
  Misses      29515    29515           
  Partials      690      690           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0a3b59c
packages 40.65% <0.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx 1.09% <ø> (ø)
...irdweb/src/react/web/wallets/in-app/WalletAuth.tsx 1.34% <0.00%> (ø)

... and 2 files with indirect coverage changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants