Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the UI components of the dashboard, particularly around user account management, by updating the MobileBurgerMenuButton, TeamHeader, and SecondaryNav, and introducing new storybook entries for the TeamHeaderLoggedOut variants.

Detailed summary

  • Added type="loggedIn" to MobileBurgerMenuButton in AccountHeaderUI and TeamHeaderUI.
  • Updated SecondaryNav to include AccountButton for logged-in users.
  • Introduced Variants function for TeamHeaderLoggedOut with mobile and desktop stories.
  • Enhanced MobileBurgerMenuButton to handle both logged-in and logged-out states.
  • Refactored TeamHeaderLoggedOutDesktopUI and TeamHeaderLoggedOutMobileUI to utilize SecondaryNavLinks and improve layout.
  • Modified CmdKSearch component to accept className as a prop.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 5:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 5:59pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 5:59pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 5:59pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 24, 2024 19:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 24, 2024 19:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 24, 2024 19:35 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 68011d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 24, 2024 19:35
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 24, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (939e7ab) to head (68011d5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5160   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 939e7ab
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3.1 s (-14.4% 🔽) 3.9 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 6.8 s (-6.23% 🔽) 8.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 178 ms (+19.98% 🔺) 275 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 188 ms (+327.36% 🔺) 198 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 803 ms (+37.96% 🔺) 1.2 s

@MananTank MananTank changed the title Add Logged Out Variants of Team Header Add Logged Out Variant of Team Header Oct 28, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added
@MananTank MananTank force-pushed the 10-25-add_logged_out_variants_of_team_header branch from 950a436 to 68011d5 Compare October 28, 2024 17:48
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 17:48 Inactive
@graphite-app graphite-app bot merged commit 68011d5 into main Oct 28, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-25-add_logged_out_variants_of_team_header branch October 28, 2024 17:59
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 17:59 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 17:59 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 17:59 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants