Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 25, 2024

Fixes: DASH-348


PR-Codex overview

This PR primarily enhances the dashboard's contract management features by adding client-side components, improving loading and error handling, and restructuring contract metadata management. It introduces new hooks and components for better querying and displaying contract-related information.

Detailed summary

  • Added useResolveContractABI and useContractPageMetadata hooks for contract data fetching.
  • Introduced LoadingPage and ErrorPage components for better user feedback.
  • Created client-side components for various contract pages, including AccountPageClient, ContractCodePageClient, and others.
  • Refactored ContractMetadata to accommodate new data structure.
  • Implemented conditional rendering based on the contract's chain ID (e.g., handling localhost).
  • Enhanced the ContractOverviewPage to include published contract information.
  • Updated multiple pages to use the new client-side components and hooks for improved data handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 939e7ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 5:47pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 5:47pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 5:47pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 5:47pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 25, 2024 22:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 25, 2024 22:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 25, 2024 22:16 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 25, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank force-pushed the 10-26-render_contract_pages_on_client_side_for_localhost_chain branch from 05787d7 to 983a009 Compare October 25, 2024 22:19
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 25, 2024 22:19 Inactive
@MananTank MananTank marked this pull request as ready for review October 25, 2024 22:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 25, 2024 22:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 25, 2024 22:19 Inactive
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (59953f7) to head (939e7ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5185   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 59953f7
packages 40.31% <ø> (ø) Carriedforward from 59953f7

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3 s (-4.55% 🔽) 3.9 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 8.3 s (+42.96% 🔺) 10.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 188 ms (+20.31% 🔺) 284 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 229 ms (+97.79% 🔺) 239 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 447 ms (-24.06% 🔽) 794 ms

@linear
Copy link

linear bot commented Oct 25, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Merge activity

@MananTank MananTank force-pushed the 10-26-render_contract_pages_on_client_side_for_localhost_chain branch from 983a009 to 939e7ab Compare October 28, 2024 17:36
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 17:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 17:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 17:36 Inactive
@graphite-app graphite-app bot merged commit 939e7ab into main Oct 28, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 10-26-render_contract_pages_on_client_side_for_localhost_chain branch October 28, 2024 17:47
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 17:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants