-
Notifications
You must be signed in to change notification settings - Fork 619
Fix MintSupplyTab Amount form field error #5191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MintSupplyTab Amount form field error #5191
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5191 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1067 1067
Lines 55304 55304
Branches 3970 3970
=======================================
Hits 25054 25054
Misses 29557 29557
Partials 693 693
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates the validation and input handling for the minting amount in the `MintSupplyTab` component. It ensures that the amount is coerced to a number type and specifies the input type for better user experience.
### Detailed summary
- Changed `amount` validation from `z.number()` to `z.coerce.number()` to ensure the input is coerced to a number.
- Updated the `Input` component to include `type="number"` for the amount field, enhancing user input handling.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
62f0825 to
59953f7
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the validation and input handling for the amount field in the
MintSupplyTabcomponent. It changes how the amount is coerced and specifies the input type for better user experience.Detailed summary
amountvalidation fromz.number()toz.coerce.number()for better handling of input.Inputcomponent to includetype="number"for the amount field, ensuring numeric input.