Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 28, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on improving the validation and input handling for the amount field in the MintSupplyTab component. It changes how the amount is coerced and specifies the input type for better user experience.

Detailed summary

  • Changed the amount validation from z.number() to z.coerce.number() for better handling of input.
  • Updated the Input component to include type="number" for the amount field, ensuring numeric input.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 59953f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 4:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 4:45pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 4:45pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 4:45pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 14:40 Inactive
@MananTank MananTank marked this pull request as ready for review October 28, 2024 14:40
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 28, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Oct 28, 2024 — with Graphite App
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (7aab5ca) to head (59953f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5191   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7aab5ca
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 521 ms (-9.24% 🔽) 1.4 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 1.3 s (-11.29% 🔽) 3.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 31 ms (-10.03% 🔽) 127 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 267 ms (+1119.93% 🔺) 277 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 454 ms (+166.52% 🔺) 801 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the validation and input handling for the minting amount in the `MintSupplyTab` component. It ensures that the amount is coerced to a number type and specifies the input type for better user experience.

### Detailed summary
- Changed `amount` validation from `z.number()` to `z.coerce.number()` to ensure the input is coerced to a number.
- Updated the `Input` component to include `type="number"` for the amount field, enhancing user input handling.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-28-fix_mintsupplytab_amount_form_field_error branch from 62f0825 to 59953f7 Compare October 28, 2024 16:35
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 16:35 Inactive
@graphite-app graphite-app bot merged commit 59953f7 into main Oct 28, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 10-28-fix_mintsupplytab_amount_form_field_error branch October 28, 2024 16:45
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 16:45 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 16:45 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 16:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants