Fix API key creation on embed page #5192

MananTank · 2024-10-28T16:20:45Z

PR-Codex overview

This PR introduces a new feature for pre-filling API key creation forms and enhances the CreateAPIKeyDialog component. It also updates the EmbedSetup component to include a modal for creating API keys and adjusts the handling of user interactions based on account status.

Detailed summary

Added CreateAPIKeyPrefillOptions type for pre-filling API key forms.
Introduced DesktopAPIKeyWordingWithPrefill story for testing.
Modified CreateAPIKeyDialogProps and CreateAPIKeyDialogUI to accept prefill prop.
Updated CreateAPIKeyForm to utilize pre-fill values.
Implemented LazyCreateAPIKeyDialog in EmbedSetup for API key creation.
Adjusted button behavior in EmbedSetup to show modal based on user account status.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-28T16:20:49Z

⚠️ No Changeset found

Latest commit: 486cd4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-10-28T16:20:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 6:10pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 28, 2024 6:10pm
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 28, 2024 6:10pm
wallet-ui	⬜️ Skipped (Inspect)	Oct 28, 2024 6:10pm

graphite-app · 2024-10-28T16:20:50Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

MananTank · 2024-10-28T16:21:00Z

Fix API key creation on embed page #5192 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

linear · 2024-10-28T16:21:12Z

DASH-340 Unable to create Client ID from Embed page in Dashboard

github-actions · 2024-10-28T16:24:10Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.9 KB (0%)	859 ms (0%)	983 ms (+70.18% 🔺)	1.9 s
thirdweb (cjs)	102.73 KB (0%)	2.1 s (0%)	1.5 s (+12.87% 🔺)	3.6 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	49 ms (+56.69% 🔺)	146 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	235 ms (+1414.01% 🔺)	245 ms
thirdweb/react (minimal + tree-shaking)	17.34 KB (0%)	347 ms (0%)	184 ms (+79.75% 🔺)	531 ms

codecov · 2024-10-28T16:34:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (68011d5) to head (486cd4a).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5192   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 68011d5
packages	`40.31% <ø> (ø)`		Carriedforward from 68011d5

*This pull request uses carry forward flags. Click here to find out more.

graphite-app · 2024-10-28T17:36:05Z

Merge activity

Oct 28, 1:36 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 28, 2:11 PM EDT: A user merged this pull request with the Graphite merge queue.

Fixes: DASH-340  --- ## PR-Codex overview This PR focuses on enhancing the `CreateAPIKey` functionality by introducing prefill options for the API key creation process, improving the user interface for creating API keys, and adding a modal for better user experience. ### Detailed summary - Added `CreateAPIKeyPrefillOptions` type. - Introduced `DesktopAPIKeyWordingWithPrefill` story. - Updated `CreateAPIKeyDialogProps` to include `prefill`. - Modified `CreateAPIKeyDialogUI` to accept and use `prefill`. - Enhanced `CreateAPIKeyForm` to utilize prefill values. - Integrated `LazyCreateAPIKeyDialog` in the `EmbedSetup` component. - Updated button behavior to show modal for creating API keys. - Improved user prompts for signing in when no active account is detected. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 16:20 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 16:20 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 16:20 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 28, 2024

MananTank marked this pull request as ready for review October 28, 2024 16:21

MananTank requested review from jnsdls and joaquim-verges as code owners October 28, 2024 16:21

MananTank force-pushed the 10-28-fix_client_id_key_creation_on_embed_page branch from df20d22 to 4af2fee Compare October 28, 2024 16:29

vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 16:29 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 16:29 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 16:29 Inactive

MananTank changed the title ~~Fix Client ID key creation on embed page~~ Fix API key creation on embed page Oct 28, 2024

vercel bot deployed to Preview – thirdweb-www October 28, 2024 16:40 View deployment

jnsdls approved these changes Oct 28, 2024

View reviewed changes

MananTank force-pushed the 10-28-fix_client_id_key_creation_on_embed_page branch from 4af2fee to 486cd4a Compare October 28, 2024 18:00

vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 18:00 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 18:00 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 18:00 Inactive

vercel bot deployed to Preview – thirdweb-www October 28, 2024 18:10 View deployment

graphite-app bot merged commit 486cd4a into main Oct 28, 2024
28 checks passed

graphite-app bot deleted the 10-28-fix_client_id_key_creation_on_embed_page branch October 28, 2024 18:11

vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 18:11 Inactive

vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 18:11 Inactive

vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 18:11 Inactive

vercel bot deployed to Production – thirdweb-www October 28, 2024 18:22 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix API key creation on embed page #5192

Fix API key creation on embed page #5192

MananTank commented Oct 28, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

vercel bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 28, 2024

Uh oh!

MananTank commented Oct 28, 2024

Uh oh!

linear bot commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix API key creation on embed page #5192

Fix API key creation on embed page #5192

Conversation

MananTank commented Oct 28, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

MananTank commented Oct 28, 2024

Uh oh!

linear bot commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Oct 28, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Oct 28, 2024 •

edited

Loading

vercel bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading

codecov bot commented Oct 28, 2024 •

edited

Loading

graphite-app bot commented Oct 28, 2024 •

edited

Loading