-
Notifications
You must be signed in to change notification settings - Fork 619
Fix hsl color preview and improved color-picker UI for connect playground #5193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hsl color preview and improved color-picker UI for connect playground #5193
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
size-limit report 📦
|
Merge activity
|
…ound (#5193) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the color selection functionality in the `ColorInput` component by integrating a new `Popover` UI from `@radix-ui/react-popover` and a color picker from `react-pick-color`. It also updates the dependencies in `package.json`. ### Detailed summary - Removed the `ColorInput.module.css` file. - Added `@radix-ui/react-popover` and `react-pick-color` to `package.json`. - Updated `ColorInput` component to use `Popover` for color selection. - Integrated `ColorPicker` within the `PopoverContent`. - Refactored `onChange` handling in `ColorInput`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
6e1b93d to
efc8bb7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5193 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1067 1067
Lines 55304 55304
Branches 3970 3970
=======================================
Hits 25054 25054
Misses 29557 29557
Partials 693 693
*This pull request uses carry forward flags. Click here to find out more. |

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on updating the
ColorInputcomponent to use a newPopoverfor color selection and introduces a new dependency,react-pick-color, for enhanced color picking functionality. It also updates thepackage.jsonto include new dependencies.Detailed summary
ColorInput.module.css.@radix-ui/react-popoverandreact-pick-colortopackage.json.ColorInputinColorInput/index.tsxto use aPopoverfor color selection.ColorFormGroup.tsxto reflect changes inColorInput.Popovercomponents inpopover.tsx.