Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 28, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the ColorInput component to use a new Popover for color selection and introduces a new dependency, react-pick-color, for enhanced color picking functionality. It also updates the package.json to include new dependencies.

Detailed summary

  • Deleted ColorInput.module.css.
  • Added @radix-ui/react-popover and react-pick-color to package.json.
  • Refactored ColorInput in ColorInput/index.tsx to use a Popover for color selection.
  • Updated ColorFormGroup.tsx to reflect changes in ColorInput.
  • Introduced Popover components in popover.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:35pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:35pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:35pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:35pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: efc8bb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Oct 28, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3.9 s (+28.43% 🔺) 4.7 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 7 s (-1.77% 🔽) 9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 425 ms (+197.58% 🔺) 522 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 43 ms (-80.19% 🔽) 53 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 1.1 s (+144.32% 🔺) 1.4 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Merge activity

…ound (#5193)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the color selection functionality in the `ColorInput` component by integrating a new `Popover` UI from `@radix-ui/react-popover` and a color picker from `react-pick-color`. It also updates the dependencies in `package.json`.

### Detailed summary
- Removed the `ColorInput.module.css` file.
- Added `@radix-ui/react-popover` and `react-pick-color` to `package.json`.
- Updated `ColorInput` component to use `Popover` for color selection.
- Integrated `ColorPicker` within the `PopoverContent`.
- Refactored `onChange` handling in `ColorInput`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (74d113c) to head (efc8bb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5193   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 74d113c
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants