Skip to content

Conversation

@edwardysun
Copy link
Contributor

@edwardysun edwardysun commented Oct 29, 2024

Problem solved

Fixes https://linear.app/thirdweb/issue/ENG-2/better-enforce-linear-use


PR-Codex overview

This PR introduces a GitHub Actions workflow that checks for specific keywords in the pull request body to ensure linked issues are mentioned.

Detailed summary

  • Added a new workflow file: .github/workflows/linear.yml.
  • Defined a workflow named Check for "linear" in pull request body.
  • Triggered on pull request events (opened and edited).
  • Created a job check_linear_in_pr_body to verify the presence of keywords "CNCT" or "DASH" in the PR body.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 953b9c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 9:10pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 9:10pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 9:10pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 9:10pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 2.2 s (-44.76% 🔽) 3 s
thirdweb (cjs) 102.88 KB (0%) 2.1 s (0%) 6.1 s (+9.34% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 117 ms (-35.01% 🔽) 214 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 119 ms (+160.25% 🔺) 129 ms
thirdweb/react (minimal + tree-shaking) 17 KB (0%) 341 ms (0%) 549 ms (+64.51% 🔺) 889 ms

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.37%. Comparing base (88e96de) to head (f81ffa9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5216   +/-   ##
=======================================
  Coverage   45.37%   45.37%           
=======================================
  Files        1067     1067           
  Lines       55446    55446           
  Branches     3989     3989           
=======================================
  Hits        25157    25157           
  Misses      29598    29598           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 88e96de
packages 40.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@linear
Copy link

linear bot commented Oct 29, 2024

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 1, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 1, 2024

Merge activity

## Problem solved

Fixes https://linear.app/thirdweb/issue/ENG-2/better-enforce-linear-use

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a GitHub Actions workflow to check the pull request body for specific keywords ("CNCT" or "DASH"). If these keywords are found, it confirms a linked issue; otherwise, it fails the check.

### Detailed summary
- Added a workflow named `Check for "linear" in pull request body` in `.github/workflows/linear.yml`.
- Configured the workflow to trigger on `pull_request` events (opened and edited).
- Implemented a job `check_linear_in_pr_body` to verify the presence of keywords in the PR body.
- Utilized `curl` to fetch the PR body and `grep` to search for keywords.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants