Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 31, 2024

Problem solved

Fixes CNCT-2149


PR-Codex overview

This PR focuses on enhancing the layout of the ecosystem-header.client.tsx component by restructuring the HTML elements for better organization and adding a link to the ecosystem's site.

Detailed summary

  • Changed the outer div class from flex items-center gap-1 to flex flex-col gap-1.
  • Wrapped the existing content in a new inner div with the class flex items-center gap-1.
  • Added a new div with a link to the ecosystem's site, using the href attribute to construct the URL dynamically.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 31, 2024 08:41 Inactive
@vercel
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 9:00am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 31, 2024 9:00am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 31, 2024 9:00am
wallet-ui ⬜️ Skipped (Inspect) Oct 31, 2024 9:00am

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 31, 2024 08:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 31, 2024 08:41 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: bd10ebf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 31, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 31, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges marked this pull request as ready for review October 31, 2024 08:42
@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.43%. Comparing base (60629e3) to head (bd10ebf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5248      +/-   ##
==========================================
+ Coverage   45.31%   45.43%   +0.11%     
==========================================
  Files        1068     1067       -1     
  Lines       55461    55435      -26     
  Branches     3989     4010      +21     
==========================================
+ Hits        25132    25185      +53     
+ Misses      29637    29559      -78     
+ Partials      692      691       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 60629e3
packages 40.48% <ø> (+0.14%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 6 files with indirect coverage changes

@joaquim-verges joaquim-verges force-pushed the feat_add_ecosystem_URL_display_in_header branch from 2461f81 to bd10ebf Compare October 31, 2024 08:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 31, 2024 08:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 31, 2024 08:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 31, 2024 08:43 Inactive
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 3.2 s (+34.43% 🔺) 4 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 7.5 s (+12.71% 🔺) 9.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 176 ms (+42.68% 🔺) 272 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 67 ms (+31.5% 🔺) 77 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 756 ms (+0.46% 🔺) 1.2 s

@linear
Copy link

linear bot commented Oct 31, 2024

@joaquim-verges joaquim-verges merged commit ae217a3 into main Oct 31, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the feat_add_ecosystem_URL_display_in_header branch October 31, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants