[Dashboard] Remove chakra: BatchUpload drawer + other minor changes #5259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5259 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1067 1067
Lines 55449 55449
Branches 3989 3989
=======================================
Hits 25157 25157
Misses 29601 29601
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
This was referenced Nov 1, 2024
jnsdls
requested changes
Nov 1, 2024
kien-ngo
force-pushed
the
kien/chakra-cleanup-batch-upload-drawer
branch
from
6fe0f24 to
b031c36
Compare
kien-ngo
force-pushed
the
kien/chakra-cleanup-batch-upload-drawer
branch
from
b031c36 to
bec6e9d
Compare
jnsdls
requested changes
Nov 2, 2024
kien-ngo
force-pushed
the
kien/chakra-cleanup-batch-upload-drawer
branch
from
bec6e9d to
0e78d34
Compare
graphite-app
bot
added
the
merge-queue
jnsdls
approved these changes
Nov 2, 2024
Contributor
Merge activity
|
…5259) Made the BatchUpload drawer more clean looking basically <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the `ClaimConditions` and `BatchLazyMint` components in the dashboard by refining input handling, restructuring layouts, and enhancing user interaction through better feedback and state management. ### Detailed summary - Changed `isDisabled` prop to `disabled` in `PhaseNameInput`. - Restructured layout in `ClaimConditions` for better spacing and organization. - Updated `BatchLazyMintButton` to use `Sheet` instead of `Drawer`. - Improved state management in `BatchLazyMintButton` for opening and closing the sheet. - Refactored `BatchLazyMint` to use a `<form>` instead of `<Container>`. - Simplified file upload instructions and requirements in `UploadStep`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
kien/chakra-cleanup-batch-upload-drawer
branch
from
0e78d34 to
21d794c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the BatchUpload drawer more clean looking basically
PR-Codex overview
This PR focuses on improving the UI components for the claim conditions form and batch lazy minting feature in a dashboard application. It includes updates to input handling, layout adjustments, and the introduction of a new sheet component for better user interaction.
Detailed summary
disabledprop inPhaseNameInputcomponent.ClaimConditionscomponent for better spacing.DrawerwithSheetinBatchLazyMintButtonfor enhanced UX.BatchLazyMintButton.BatchLazyMintcomponent.UploadStepcomponent.