Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 4, 2024

Fixes: DASH-395


PR-Codex overview

This PR modifies the isLoginRequired function in the auth.ts file to change how it determines if a login is required for certain paths. It replaces the previous array-based check with a more explicit conditional check based on the first segments of the path.

Detailed summary

  • Removed the LOGGED_IN_ONLY_PATHS array and its contents.
  • Introduced a new method to check the path by splitting the pathname.
  • Added conditions to check if the first segment is dashboard, team, or cli.
  • Added a condition to check if the path is /contracts/publish.
  • Simplified the return logic to return true or false based on the checks.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 2eaf773

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 9:34pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 4, 2024 9:34pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 4, 2024 9:34pm
wallet-ui ⬜️ Skipped (Inspect) Nov 4, 2024 9:34pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 4, 2024 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 4, 2024 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 4, 2024 21:06 Inactive
@MananTank MananTank marked this pull request as ready for review November 4, 2024 21:06
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 4, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@linear
Copy link

linear bot commented Nov 4, 2024

@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.44%. Comparing base (c0b8750) to head (2eaf773).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5291   +/-   ##
=======================================
  Coverage   45.44%   45.44%           
=======================================
  Files        1067     1067           
  Lines       55459    55459           
  Branches     4009     4009           
=======================================
  Hits        25206    25206           
  Misses      29562    29562           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c0b8750
packages 40.51% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 860 ms (0%) 2.7 s (-3.18% 🔽) 3.6 s
thirdweb (cjs) 103.02 KB (0%) 2.1 s (0%) 7.8 s (+36.38% 🔺) 9.9 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 289 ms (-9.66% 🔽) 386 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (-79.38% 🔽) 57 ms
thirdweb/react (minimal + tree-shaking) 17.57 KB (0%) 352 ms (0%) 582 ms (+90.44% 🔺) 933 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 4, 2024

Merge activity

@jnsdls jnsdls force-pushed the 11-05-fix__dashboards_path_redirecting_to__login branch from 94859ab to 2eaf773 Compare November 4, 2024 21:17
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 4, 2024 21:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 4, 2024 21:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 4, 2024 21:17 Inactive
@graphite-app graphite-app bot merged commit 2eaf773 into main Nov 4, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 11-05-fix__dashboards_path_redirecting_to__login branch November 4, 2024 21:35
@vercel vercel bot temporarily deployed to Production – docs-v2 November 4, 2024 21:35 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 4, 2024 21:35 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 4, 2024 21:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants