-
Notifications
You must be signed in to change notification settings - Fork 620
Fix /dashboards path redirecting to /login #5291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix /dashboards path redirecting to /login #5291
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5291 +/- ##
=======================================
Coverage 45.44% 45.44%
=======================================
Files 1067 1067
Lines 55459 55459
Branches 4009 4009
=======================================
Hits 25206 25206
Misses 29562 29562
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
94859ab to
2eaf773
Compare

Fixes: DASH-395
PR-Codex overview
This PR modifies the
isLoginRequiredfunction in theauth.tsfile to change how it determines if a login is required for certain paths. It replaces the previous array-based check with a more explicit conditional check based on the first segments of the path.Detailed summary
LOGGED_IN_ONLY_PATHSarray and its contents.pathname.dashboard,team, orcli./contracts/publish.trueorfalsebased on the checks.