Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 5, 2024

PR-Codex overview

This PR focuses on updating the @chromatic-com/storybook and various @storybook packages to version 8.4.2, along with some updates in the pnpm-lock.yaml file. It also includes the addition of types for certain packages in packages/thirdweb/package.json.

Detailed summary

  • Updated @chromatic-com/storybook from 2.0.2 to 3.2.2 in apps/dashboard/package.json and packages/thirdweb/package.json.
  • Updated all @storybook/* packages to version 8.4.2.
  • Updated storybook version from 8.4.1 to 8.4.2 in both apps/dashboard/package.json and packages/thirdweb/package.json.
  • Adjusted typesVersions in packages/thirdweb/package.json to include specific paths for TypeScript definitions.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 6b04d75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:46am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:46am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:46am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:46am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Nov 5, 2024
@jnsdls jnsdls marked this pull request as ready for review November 5, 2024 06:14
Copy link
Member Author

jnsdls commented Nov 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@socket-security
Copy link

socket-security bot commented Nov 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@chromatic-com/storybook@3.2.2 Transitive: filesystem +8 6.37 MB ghengeveld
npm/@storybook/addon-essentials@8.4.2 Transitive: environment, eval, filesystem, unsafe +33 13.8 MB shilman
npm/@storybook/addon-interactions@8.4.2 Transitive: environment +10 3.72 MB domyen, ghengeveld, jreinhold, ...8 more
npm/@storybook/addon-links@8.4.2 None +4 299 kB domyen, ghengeveld, jreinhold, ...8 more
npm/@storybook/addon-onboarding@8.4.2 None +2 450 kB shilman
npm/@storybook/addon-viewport@8.4.2 Transitive: environment +2 92.6 kB shilman
npm/@storybook/nextjs@8.4.2 environment Transitive: eval, filesystem, network, shell, unsafe +504 47.5 MB shilman
npm/@storybook/react-vite@8.4.2 Transitive: environment, eval, filesystem, shell, unsafe +93 15.1 MB shilman
npm/@storybook/react@8.4.2 environment +5 934 kB shilman
npm/@storybook/test@8.4.2 environment, eval +53 9.33 MB shilman
npm/storybook@8.4.2 Transitive: environment, eval, filesystem, network, shell, unsafe +44 23.1 MB shilman

🚮 Removed packages: npm/@chromatic-com/storybook@2.0.2, npm/@storybook/addon-essentials@8.4.1, npm/@storybook/addon-interactions@8.4.1, npm/@storybook/addon-links@8.4.1, npm/@storybook/addon-onboarding@8.4.1, npm/@storybook/addon-viewport@8.4.1, npm/@storybook/nextjs@8.4.1, npm/@storybook/react-vite@8.4.1, npm/@storybook/react@8.4.1, npm/@storybook/test@8.4.1, npm/storybook@8.4.1

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 2.9 s (-40.06% 🔽) 3.8 s
thirdweb (cjs) 103 KB (0%) 2.1 s (0%) 8.2 s (+15.37% 🔺) 10.2 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 281 ms (+68.22% 🔺) 378 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 150 ms (+49.26% 🔺) 160 ms
thirdweb/react (minimal + tree-shaking) 17.51 KB (0%) 351 ms (0%) 1.1 s (+3.27% 🔺) 1.5 s

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.56%. Comparing base (93a382b) to head (6b04d75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5306   +/-   ##
=======================================
  Coverage   45.56%   45.56%           
=======================================
  Files        1067     1067           
  Lines       55487    55487           
  Branches     4030     4031    +1     
=======================================
+ Hits        25282    25283    +1     
+ Misses      29515    29514    -1     
  Partials      690      690           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 93a382b
packages 40.65% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants