Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 5, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the DashboardLayout and DropPage components by adding error handling, metadata generation, and support for new blockchain features. It also includes updates to the NftMint component for improved user interaction and visual representation.

Detailed summary

  • Added AppFooter and ErrorProvider to DashboardLayout.
  • Introduced DropPageData type in data.ts.
  • Updated DROP_PAGES with new NFT metadata and thumbnails.
  • Enhanced DropPage for dynamic metadata generation.
  • Improved NftMint component with quantity selection and custom address minting.
  • Integrated CustomConnectWallet for wallet connection handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 1 resolved Nov 12, 2024 2:42pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 12, 2024 2:42pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 12, 2024 2:42pm
wallet-ui ⬜️ Skipped (Inspect) Nov 12, 2024 2:42pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 07:52 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 7d34a8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 07:52 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 07:52 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 5, 2024
Copy link
Contributor Author

kien-ngo commented Nov 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo changed the title update Add Drop page for minting NFTs with partners Nov 5, 2024
@kien-ngo kien-ngo marked this pull request as ready for review November 5, 2024 07:52
@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (9584885) to head (7d34a8f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5307   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9584885
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 3.1 s (+43.11% 🔺) 3.9 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 6.2 s (+8.75% 🔺) 8.3 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 197 ms (+108.06% 🔺) 294 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 228 ms (+112.38% 🔺) 238 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 709 ms (+80.97% 🔺) 1.1 s

@kien-ngo kien-ngo marked this pull request as draft November 5, 2024 12:33
@kien-ngo kien-ngo self-assigned this Nov 5, 2024
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 12:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 12:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 12:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 12:21 Inactive
Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current opengraph-image.tsx is not very useful - @kien-ngo leaving it upto you to update it later on. Approving the PR for now

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `Dashboard` layout and functionality for NFT drops, including improved metadata handling, wallet connection, and minting features.

### Detailed summary
- Added `AppFooter` and `ErrorProvider` in `DashboardLayout`.
- Introduced `DropPageData` type in `data.ts`.
- Enhanced `NftMint` component with quantity selection and custom address options.
- Integrated OpenGraph image generation for NFT drops.
- Updated `CustomConnectWallet` to accept `chain` prop.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 14:39 Inactive
@graphite-app graphite-app bot merged commit 7d34a8f into main Nov 12, 2024
32 checks passed
@graphite-app graphite-app bot deleted the kien/zerion-mint branch November 12, 2024 14:44
@vercel vercel bot temporarily deployed to Production – wallet-ui November 12, 2024 14:44 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 12, 2024 14:44 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 12, 2024 14:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants