Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 5, 2024

Problem solved

Fixes CNCT-2225

CleanShot 2024-11-05 at 21.47.45@2x.png


PR-Codex overview

This PR introduces a new section in the AccountFactories component to display default account factories and enhance user interaction with account factory contracts.

Detailed summary

  • Added a section for default account factories with a heading and description.
  • Introduced a TWTable component to display two default account factories (DEFAULT_ACCOUNT_FACTORY_V0_6 and DEFAULT_ACCOUNT_FACTORY_V0_7).
  • Added a new section for user account factories with a heading and description.
  • Implemented a DefaultFactory type and created columns for the TWTable:
    • Name
    • Network (set to "All networks")
    • Contract address (with a CopyAddressButton)
    • Entrypoint Version

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 8:41pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 5, 2024 8:41pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 5, 2024 8:41pm
wallet-ui ⬜️ Skipped (Inspect) Nov 5, 2024 8:41pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 08:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 08:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 08:49 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 180d563

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 5, 2024
@linear
Copy link

linear bot commented Nov 5, 2024

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.59%. Comparing base (43b7c27) to head (180d563).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5308   +/-   ##
=======================================
  Coverage   45.59%   45.59%           
=======================================
  Files        1069     1069           
  Lines       55584    55584           
  Branches     4045     4045           
=======================================
  Hits        25342    25342           
  Misses      29552    29552           
  Partials      690      690           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 43b7c27
packages 40.70% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@joaquim-verges joaquim-verges marked this pull request as ready for review November 5, 2024 08:50
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 5.1 s (+164.47% 🔺) 5.9 s
thirdweb (cjs) 103 KB (0%) 2.1 s (0%) 6.4 s (-9.58% 🔽) 8.5 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 394 ms (+99.79% 🔺) 491 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 161 ms (-20.68% 🔽) 171 ms
thirdweb/react (minimal + tree-shaking) 17.51 KB (0%) 351 ms (0%) 713 ms (+24.62% 🔺) 1.1 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024

Merge activity

## Problem solved

Fixes CNCT-2225

![CleanShot 2024-11-05 at 21.47.45@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/GGPGC1k4LEcpDtkOsVBe/d6321c9a-f6d9-42cd-af14-41165c2ace6d.png)

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `AccountFactories` component by introducing a section for default account factories and a table to display them. It improves user guidance on deploying custom factories and organizes the layout for better clarity.

### Detailed summary
- Added a section for default account factories with a description and link.
- Introduced `TWTable` to display default account factories (`AccountFactory (v0.6)` and `AccountFactory (v0.7)`).
- Created a new section for user account factories with relevant information and a link.
- Defined `DefaultFactory` type and created table columns using `createColumnHelper`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the feat_dashboard_add_default_account_factories_table branch from 93f0132 to 180d563 Compare November 5, 2024 20:30
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 20:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 20:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 20:30 Inactive
@graphite-app graphite-app bot merged commit 180d563 into main Nov 5, 2024
32 checks passed
@graphite-app graphite-app bot deleted the feat_dashboard_add_default_account_factories_table branch November 5, 2024 20:41
@vercel vercel bot temporarily deployed to Production – wallet-ui November 5, 2024 20:41 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 5, 2024 20:41 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 5, 2024 20:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants