Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 6, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the displayName and removing the isBeta flag for the modular-contracts in the explore.ts file, indicating a shift towards a more stable release of the feature.

Detailed summary

  • Changed displayName from "Modular Contracts (Beta)" to "Modular Contracts".
  • Removed the isBeta flag set to true.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 1:18am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 6, 2024 1:18am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 6, 2024 1:18am
wallet-ui ⬜️ Skipped (Inspect) Nov 6, 2024 1:18am

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 00:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 00:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 00:33 Inactive
@kien-ngo kien-ngo marked this pull request as ready for review November 6, 2024 00:33
Copy link
Contributor Author

kien-ngo commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 6, 2024
@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.61%. Comparing base (87e736d) to head (9fb2a71).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5314   +/-   ##
=======================================
  Coverage   45.61%   45.61%           
=======================================
  Files        1068     1068           
  Lines       55556    55556           
  Branches     4047     4047           
=======================================
  Hits        25341    25341           
  Misses      29525    29525           
  Partials      690      690           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 87e736d
packages 40.72% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 1.6 s (+39.94% 🔺) 2.5 s
thirdweb (cjs) 103 KB (0%) 2.1 s (0%) 3 s (+5.99% 🔺) 5.1 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 139 ms (+78.34% 🔺) 236 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 21 ms (-35.92% 🔽) 31 ms
thirdweb/react (minimal + tree-shaking) 17.51 KB (0%) 351 ms (0%) 162 ms (+25.53% 🔺) 512 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `displayName` and removing the `isBeta` flag for the `modular-contracts` entry in the `explore.ts` file, indicating a shift from a beta status to a more stable release.

### Detailed summary
- Changed `displayName` from "Modular Contracts (Beta)" to "Modular Contracts".
- Removed the `isBeta` property set to `true`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the kien/remove-modular-contract-beta-tag branch from b247494 to 9fb2a71 Compare November 6, 2024 01:06
@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 9fb2a71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 01:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 01:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 01:06 Inactive
@graphite-app graphite-app bot merged commit 9fb2a71 into main Nov 6, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the kien/remove-modular-contract-beta-tag branch November 6, 2024 01:19
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 6, 2024 01:19 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 6, 2024 01:19 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 6, 2024 01:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants