Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 6, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the metadata returned by the createMetadata function in the metadata.ts file by adding a description and a siteName field.

Detailed summary

  • Added description: obj.description to the returned object.
  • Added siteName: "thirdweb docs" to the returned object.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:15pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Nov 6, 2024 10:15pm
thirdweb-www ⬜️ Skipped (Inspect) Nov 6, 2024 10:15pm
wallet-ui ⬜️ Skipped (Inspect) Nov 6, 2024 10:15pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 6, 2024 21:52 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: ad77293

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 6, 2024
@MananTank MananTank marked this pull request as ready for review November 6, 2024 21:52
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.75%. Comparing base (f5f5ae6) to head (ad77293).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5331   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files        1069     1069           
  Lines       55606    55606           
  Branches     4074     4074           
=======================================
  Hits        25444    25444           
  Misses      29473    29473           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f5f5ae6
packages 40.91% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 217 ms (+53.07% 🔺) 1.1 s
thirdweb (cjs) 103.05 KB (0%) 2.1 s (0%) 368 ms (+22.35% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 38 ms (+243.69% 🔺) 135 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 45 ms (+788.36% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 17.56 KB (0%) 352 ms (0%) 134 ms (+449.45% 🔺) 485 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds a `description` field and a `siteName` property to the metadata returned by the `createMetadata` function in the `metadata.ts` file.

### Detailed summary
- Added `description: obj.description` to the returned object in `createMetadata`.
- Added `siteName: "thirdweb docs"` to the returned object in `createMetadata`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 11-07-fix_missing_description_meta_tag_add_og_site_name_in_portal branch from d11d151 to ad77293 Compare November 6, 2024 22:10
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 22:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 6, 2024 22:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 22:10 Inactive
@graphite-app graphite-app bot merged commit ad77293 into main Nov 6, 2024
29 of 31 checks passed
@graphite-app graphite-app bot deleted the 11-07-fix_missing_description_meta_tag_add_og_site_name_in_portal branch November 6, 2024 22:13
@vercel vercel bot temporarily deployed to Production – thirdweb-www November 6, 2024 22:13 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 6, 2024 22:13 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 6, 2024 22:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants