Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 6, 2024

PR-Codex overview

This PR focuses on enhancing the build process in the turbo.json and package.json files. It adds a new postbuild step that includes additional outputs and modifies the existing postbuild command to run next-sitemap after extracting search data.

Detailed summary

  • Added a new postbuild section in turbo.json with dependencies and outputs.
  • Updated the postbuild command in apps/portal/package.json to run next-sitemap after extract-search-data.
  • Maintained the extract-search-data command without changes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:32pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:32pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:32pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:32pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 0ad80db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls marked this pull request as ready for review November 6, 2024 21:58
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 6, 2024
Copy link
Member Author

jnsdls commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.75%. Comparing base (ad77293) to head (0ad80db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5332   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files        1069     1069           
  Lines       55606    55606           
  Branches     4074     4074           
=======================================
  Hits        25444    25444           
  Misses      29473    29473           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ad77293
packages 40.91% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 575 ms (+0.95% 🔺) 1.5 s
thirdweb (cjs) 103.05 KB (0%) 2.1 s (0%) 1.3 s (+2.31% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 43 ms (-45.05% 🔽) 140 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 88 ms (+631.38% 🔺) 98 ms
thirdweb/react (minimal + tree-shaking) 17.56 KB (0%) 352 ms (0%) 223 ms (+204.01% 🔺) 575 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2024

Merge activity

@jnsdls jnsdls force-pushed the 11-06-fix_postbuild_cache branch from 272b324 to a14440a Compare November 6, 2024 22:21
jnsdls added a commit that referenced this pull request Nov 6, 2024
@jnsdls jnsdls force-pushed the 11-06-fix_postbuild_cache branch from a14440a to 1f1243a Compare November 6, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants