[Dashboard] Fix: Cleanup dashboard UI #5344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/dashboard/src/app/team/[team_slug]/[project_slug]/page.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5344 +/- ##
=======================================
Coverage 45.76% 45.76%
=======================================
Files 1069 1069
Lines 55606 55606
Branches 4074 4074
=======================================
Hits 25446 25446
Misses 29471 29471
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
gregfromstl
removed
the
merge-queue
graphite-app
bot
added
the
merge-queue
graphite-app
bot
removed
the
merge-queue
joaquim-verges
approved these changes
Nov 8, 2024
gregfromstl
added
the
merge-queue
CNCT-2282 <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on refactoring components related to analytics and charts in the dashboard, removing unused components, improving data handling, and enhancing UI elements for better responsiveness and clarity. ### Detailed summary - Deleted `ConnectSDKCard.tsx` and `ConnectAnalyticsDashboard.tsx` files. - Removed the `Analytics` link from the sidebar. - Enhanced `PieChartCard` and `BarChart` components with better data mapping and UI adjustments. - Updated `RangeSelector` to handle local state for range and interval. - Removed unused API functions related to wallet usage. - Improved data filtering logic in `WalletDistributionCard` and `AuthMethodDistributionCard`. - Adjusted image rendering for better layout consistency in charts. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2282-cleanup-ui
branch
from
44f2216 to
d34357e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2282
PR-Codex overview
This PR focuses on refactoring various components in the dashboard application, improving the handling of analytics, and enhancing the UI elements like charts and tooltips. Additionally, it removes some unused components and optimizes data fetching.
Detailed summary
ConnectSDKCard.tsxandConnectAnalyticsDashboard.tsx.CombinedBarChartCardto includeprefetchfunctionality.PieChartCardto map over items for better data handling.BarCharttooltip width from 150px to 200px.valueFormattertoChartTooltipContent.page.tsxinstead of renderingConnectAnalyticsDashboard.RangeSelectorfor range and interval.RangeSelector.useApi.ts.UsersChartCard.WalletDistributionCardandAuthMethodDistributionCard.