Skip to content

Conversation

@ElasticBottle
Copy link
Contributor

@ElasticBottle ElasticBottle commented Nov 8, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the Page component in apps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/in-app-wallets/users/page.tsx by adding project validation and updating the client ID used in the InAppWalletUsersPageContent component.

Detailed summary

  • Added import of notFound from next/navigation.
  • Fetched the project using getProject based on team_slug and project_slug.
  • Implemented a check for the existence of project; if not found, triggers notFound().
  • Updated clientId prop in InAppWalletUsersPageContent to use project.publishableKey.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 9572db0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 4:18am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 8, 2024 4:18am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 8, 2024 4:18am
wallet-ui ⬜️ Skipped (Inspect) Nov 8, 2024 4:18am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 8, 2024
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.71%. Comparing base (5de5418) to head (9572db0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5355   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files        1070     1070           
  Lines       55670    55670           
  Branches     4083     4083           
=======================================
  Hits        25450    25450           
  Misses      29531    29531           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5de5418
packages 40.86% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@ElasticBottle ElasticBottle enabled auto-merge (squash) November 8, 2024 03:36
@ElasticBottle ElasticBottle added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 8, 2024
Copy link
Contributor Author

ElasticBottle commented Nov 8, 2024

Merge activity

  • Nov 7, 10:37 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 7, 11:15 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 7, 11:19 PM EST: A user merged this pull request with the Graphite merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.09 KB (0%) 862 ms (0%) 2.7 s (+29.48% 🔺) 3.6 s
thirdweb (cjs) 103.19 KB (0%) 2.1 s (0%) 5.5 s (+11.72% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 150 ms (-25.19% 🔽) 247 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 99 ms (+122.69% 🔺) 109 ms
thirdweb/react (minimal + tree-shaking) 17.57 KB (0%) 352 ms (0%) 502 ms (-56.62% 🔽) 853 ms

…t user content (#5355)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `Page` component in the `in-app-wallets/users` directory by adding error handling for project retrieval and updating the `clientId` property passed to `InAppWalletUsersPageContent`.

### Detailed summary
- Imported `notFound` from `next/navigation`.
- Fetched the `project` using `getProject` based on `team_slug` and `project_slug`.
- Added a check to call `notFound()` if the `project` is not found.
- Updated `clientId` prop in `InAppWalletUsersPageContent` to use `project.publishableKey`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@ElasticBottle ElasticBottle force-pushed the winston/fix-in-app-wallet-user branch from 085e2a4 to 9572db0 Compare November 8, 2024 04:15
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 8, 2024 04:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 8, 2024 04:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 8, 2024 04:15 Inactive
@graphite-app graphite-app bot merged commit 9572db0 into main Nov 8, 2024
31 checks passed
@graphite-app graphite-app bot deleted the winston/fix-in-app-wallet-user branch November 8, 2024 04:19
@vercel vercel bot temporarily deployed to Production – wallet-ui November 8, 2024 04:19 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 8, 2024 04:19 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 8, 2024 04:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants