-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard]: fix client ID not being passed correctly to in app wallet user content #5355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5355 +/- ##
=======================================
Coverage 45.71% 45.71%
=======================================
Files 1070 1070
Lines 55670 55670
Branches 4083 4083
=======================================
Hits 25450 25450
Misses 29531 29531
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Merge activity
|
size-limit report 📦
|
…t user content (#5355) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances the `Page` component in the `in-app-wallets/users` directory by adding error handling for project retrieval and updating the `clientId` property passed to `InAppWalletUsersPageContent`. ### Detailed summary - Imported `notFound` from `next/navigation`. - Fetched the `project` using `getProject` based on `team_slug` and `project_slug`. - Added a check to call `notFound()` if the `project` is not found. - Updated `clientId` prop in `InAppWalletUsersPageContent` to use `project.publishableKey`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
085e2a4 to
9572db0
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
Pagecomponent inapps/dashboard/src/app/team/[team_slug]/[project_slug]/connect/in-app-wallets/users/page.tsxby adding project validation and updating the client ID used in theInAppWalletUsersPageContentcomponent.Detailed summary
notFoundfromnext/navigation.projectusinggetProjectbased onteam_slugandproject_slug.project; if not found, triggersnotFound().clientIdprop inInAppWalletUsersPageContentto useproject.publishableKey.