-
Notifications
You must be signed in to change notification settings - Fork 619
Dashboard storybook minor cleanup + fix crashing stories #5359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5359 +/- ##
=======================================
Coverage 45.71% 45.71%
=======================================
Files 1070 1070
Lines 55670 55670
Branches 4094 4094
=======================================
Hits 25450 25450
Misses 29531 29531
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
304e586 to
597eb25
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on updating the titles in various story files to follow a consistent naming convention, improving UI component integration, and enhancing the use of the `getThirdwebClient()` function across multiple components.
### Detailed summary
- Updated titles in story files for consistency.
- Modified `StatBreakdownCard` to use a max width.
- Integrated `getThirdwebClient()` in multiple components.
- Adjusted `AccountTeamsUI` and `TeamRow` to accept `client` as a prop.
- Enhanced theme handling in the Storybook preview.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
597eb25 to
c8ad066
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on updating the titles in various story files for consistency and improving the structure of components by passing a
clientprop. Additionally, it updates the layout and theme handling in the Storybook configuration.Detailed summary
clientprop to several components, enhancing their functionality.StatBreakdownCardfor better responsiveness.