Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 8, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the titles in various story files for consistency and improving the structure of components by passing a client prop. Additionally, it updates the layout and theme handling in the Storybook configuration.

Detailed summary

  • Updated titles in multiple story files to follow a consistent naming convention.
  • Added client prop to several components, enhancing their functionality.
  • Modified layout in StatBreakdownCard for better responsiveness.
  • Improved theme handling in Storybook's preview configuration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: c8ad066

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 6:11pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 8, 2024 6:11pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 8, 2024 6:11pm
wallet-ui ⬜️ Skipped (Inspect) Nov 8, 2024 6:11pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 8, 2024 15:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 8, 2024 15:11 Inactive
@MananTank MananTank marked this pull request as ready for review November 8, 2024 15:11
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 8, 2024 15:11 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 8, 2024
Copy link
Member Author

MananTank commented Nov 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.71%. Comparing base (0bba414) to head (c8ad066).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5359   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files        1070     1070           
  Lines       55670    55670           
  Branches     4094     4094           
=======================================
  Hits        25450    25450           
  Misses      29531    29531           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0bba414
packages 40.86% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank changed the title Dashboard storybook minor cleanup Dashboard storybook minor cleanup + fix crashing stories Nov 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 2.4 s (-24.76% 🔽) 3.3 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 6.6 s (+15% 🔺) 8.7 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 499 ms (+399.07% 🔺) 596 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 36 ms (-10.43% 🔽) 46 ms
thirdweb/react (minimal + tree-shaking) 17.6 KB (0%) 353 ms (0%) 598 ms (+27.87% 🔺) 950 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 8, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on updating the titles in various story files to follow a consistent naming convention, improving UI component integration, and enhancing the use of the `getThirdwebClient()` function across multiple components.

### Detailed summary
- Updated titles in story files for consistency.
- Modified `StatBreakdownCard` to use a max width.
- Integrated `getThirdwebClient()` in multiple components.
- Adjusted `AccountTeamsUI` and `TeamRow` to accept `client` as a prop.
- Enhanced theme handling in the Storybook preview.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-08-dashboard_storybook_minor_cleanup branch from 597eb25 to c8ad066 Compare November 8, 2024 18:07
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 8, 2024 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 8, 2024 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 8, 2024 18:07 Inactive
@graphite-app graphite-app bot merged commit c8ad066 into main Nov 8, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 11-08-dashboard_storybook_minor_cleanup branch November 8, 2024 18:12
@vercel vercel bot temporarily deployed to Production – wallet-ui November 8, 2024 18:12 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 8, 2024 18:12 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 8, 2024 18:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants