Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring and enhancing the profile management features in the dashboard application. It includes improvements to contract handling, profile editing, and UI components, as well as the addition of new functions for address resolution and contract fetching.

Detailed summary

  • Removed several unused files related to profile and contract tables.
  • Updated replaceDeployerAddress function to replace specific addresses.
  • Changed useRouter to useDashboardRouter in PlaygroundMenu.
  • Added onlyMainnet parameter to getSortedDeployedContracts.
  • Made mapThirdwebPublisher function exportable.
  • Implemented resolveAddressAndEns for ENS resolution.
  • Created PublishedContracts component for displaying contracts.
  • Modified DeployedContracts to remove isPending prop.
  • Enhanced ContractTable by removing loading indicators.
  • Updated profile page to fetch and display publisher profiles.
  • Added ProfileUI component to manage profile display and editing.
  • Improved PublisherSocials component to handle social links.
  • Refactored EditProfile to use new form handling methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2024

⚠️ No Changeset found

Latest commit: 07af647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 00:36 Inactive
@vercel
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:48am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 9, 2024 1:48am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 9, 2024 1:48am
wallet-ui ⬜️ Skipped (Inspect) Nov 9, 2024 1:48am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 00:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 00:36 Inactive
@MananTank MananTank marked this pull request as ready for review November 9, 2024 00:36
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 9, 2024
@codecov
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (535e1df) to head (07af647).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5364   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 535e1df
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.07 KB (+0.04% 🔺) 862 ms (+0.04% 🔺) 3.7 s (-4.88% 🔽) 4.6 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 6.7 s (+23.91% 🔺) 8.8 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 747 ms (+281.11% 🔺) 844 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 104 ms (-81.93% 🔽) 114 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 465 ms (+6.29% 🔺) 816 ms

@MananTank MananTank changed the title Migrate profile page to tailwind and Move to app router Migrate profile page to tailwind and Move to app router and use RSCs Nov 9, 2024
@MananTank MananTank force-pushed the 11-09-migrate_profile_page_to_tailwind_and_move_to_app_router branch from 6d8066c to 53432ad Compare November 9, 2024 00:42
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 00:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 00:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 00:42 Inactive
Copy link
Member

jnsdls commented Nov 9, 2024

Merge activity

  • Nov 8, 8:11 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 8, 8:44 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 8, 8:48 PM EST: A user merged this pull request with the Graphite merge queue.

@MananTank MananTank force-pushed the 11-09-migrate_profile_page_to_tailwind_and_move_to_app_router branch from 53432ad to 8b13b9a Compare November 9, 2024 01:14
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 01:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 01:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 01:14 Inactive
@MananTank MananTank marked this pull request as draft November 9, 2024 01:29
@MananTank MananTank force-pushed the 11-09-migrate_profile_page_to_tailwind_and_move_to_app_router branch from 8b13b9a to 695cdc3 Compare November 9, 2024 01:35
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 01:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 01:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 01:35 Inactive
@MananTank MananTank marked this pull request as ready for review November 9, 2024 01:36
…5364)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on updating the profile management features within the application. It introduces new functionalities for resolving addresses and fetching published contracts while enhancing the user interface for profile editing.

### Detailed summary
- Removed unused files from the project.
- Updated `replaceDeployerAddress` to include a specific address replacement.
- Changed `PlaygroundMenu` to use `useDashboardRouter`.
- Enhanced `getSortedDeployedContracts` to handle mainnet filtering.
- Made `mapThirdwebPublisher` an exportable function.
- Added `resolveAddressAndEns` for address resolution.
- Introduced `PublishedContracts` component to display published contracts.
- Modified `DeployedContracts` to simplify contract listing logic.
- Updated `ProfileUI` to fetch and display publisher profiles.
- Enhanced `EditProfile` component for better profile editing experience.
- Improved `PublisherSocials` to streamline social media links.
- Added loading states and error handling in various components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-09-migrate_profile_page_to_tailwind_and_move_to_app_router branch from 695cdc3 to 07af647 Compare November 9, 2024 01:45
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 01:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 01:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 01:45 Inactive
@graphite-app graphite-app bot merged commit 07af647 into main Nov 9, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 11-09-migrate_profile_page_to_tailwind_and_move_to_app_router branch November 9, 2024 01:48
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 9, 2024 01:48 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 9, 2024 01:48 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 9, 2024 01:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants