Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 11, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on removing outdated components and hooks related to contract deployment and publishing, while introducing new pages and a restructured DeployableContractTable to handle contract metadata more efficiently.

Detailed summary

  • Deleted multiple files related to contract deployment and publishing.
  • Removed ContractCellContext and related types.
  • Introduced DeployMultipleContractsPage and PublishMultipleContractsPage for contract deployment and publishing.
  • Updated DeployableContractTable to fetch and display contract metadata.
  • Added SanctionedAddressesChecker to block access for sanctioned addresses.
  • Replaced Chakra UI table components with custom table components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 8:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 11, 2024 8:45pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 11, 2024 8:45pm
wallet-ui ⬜️ Skipped (Inspect) Nov 11, 2024 8:45pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 20:16 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: c6310e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 20:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 20:16 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 11, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank marked this pull request as ready for review November 11, 2024 20:17
@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (dc0ea8a) to head (c6310e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5381   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from dc0ea8a
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 507 ms (+80.96% 🔺) 1.4 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 1.1 s (-15.98% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 20 ms (-25.76% 🔽) 117 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 16 ms (+80.72% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 108 ms (+104.04% 🔺) 460 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024

Merge activity

…te to shadcn/tailwind (#5381)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on the removal of several components and hooks related to contract deployment and publishing, while introducing new pages and components for handling these processes more effectively, including improved loading states and contract metadata handling.

### Detailed summary
- Deleted several files related to contract hooks and components.
- Introduced `DeployMultipleContractsPage` and `PublishMultipleContractsPage` for contract deployment and publishing.
- Added `SanctionedAddressesChecker` to handle blocked wallet addresses.
- Updated `DeployableContractTable` to fetch and display contract metadata.
- Refactored `ContractIdImage` to utilize fetched metadata directly.
- Changed table structure in `DeployableContractTable` to use new UI components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-12-move_deploy_multiple_and_publish_multiple_pages_to_app_router_migrate_to_shadcn_tailwind branch from cc1e63b to c6310e6 Compare November 11, 2024 20:42
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 20:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 20:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 20:42 Inactive
@graphite-app graphite-app bot merged commit c6310e6 into main Nov 11, 2024
30 of 31 checks passed
@graphite-app graphite-app bot deleted the 11-12-move_deploy_multiple_and_publish_multiple_pages_to_app_router_migrate_to_shadcn_tailwind branch November 11, 2024 20:46
@vercel vercel bot temporarily deployed to Production – wallet-ui November 11, 2024 20:46 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 11, 2024 20:46 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 11, 2024 20:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants