Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 12, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on adding new network identifiers to the MismatchButton.tsx component, enhancing its capability to handle additional testnets and networks.

Detailed summary

  • Added lens sepolia network identifier with ID 37111.
  • Added zero testnet network identifier with ID 4457845.
  • Added treasure topaz network identifier with ID 978658.
  • Added zksync sepolia network identifier with ID 300.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ❌ Failed (Inspect) Nov 12, 2024 3:09pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 12, 2024 3:09pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 12, 2024 3:09pm
wallet-ui ⬜️ Skipped (Inspect) Nov 12, 2024 3:09pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 0fd49bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review November 12, 2024 11:57
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 12, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (9584885) to head (3c4541b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5391   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9584885
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 248 ms (+90.95% 🔺) 1.2 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 231 ms (+17.31% 🔺) 2.3 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 44 ms (+642.37% 🔺) 141 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 57 ms (+4008.22% 🔺) 67 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 130 ms (+329.01% 🔺) 482 ms

@joaquim-verges joaquim-verges force-pushed the feat_add_lens_sepolia_zero_testnet_and_treasure_topaz_chains branch from 0fd49bb to 3c4541b Compare November 12, 2024 15:05
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 15:05 Inactive
@joaquim-verges joaquim-verges merged commit afb6343 into main Nov 12, 2024
31 of 34 checks passed
@joaquim-verges joaquim-verges deleted the feat_add_lens_sepolia_zero_testnet_and_treasure_topaz_chains branch November 12, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants