Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 12, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the code for handling code blocks in the UI, replacing instances of CodeBlock with CodeClient and PlainTextCodeBlock, and updating styles and imports accordingly. It also adds new functionalities related to code formatting.

Detailed summary

  • Removed CodeBlock components and replaced with CodeClient or PlainTextCodeBlock.
  • Introduced getCodeHtml function to format code and convert it to HTML.
  • Added new CSS styles for dark mode support in code rendering.
  • Updated package.json to include shiki for syntax highlighting.
  • Cleaned up imports across multiple components.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 10:01pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 10:01pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 10:01pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 10:01pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 3e458c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 12, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank marked this pull request as ready for review November 12, 2024 16:11
@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.32%. Comparing base (512eeb5) to head (ff188fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5393   +/-   ##
=======================================
  Coverage   45.32%   45.32%           
=======================================
  Files        1067     1067           
  Lines       55405    55405           
  Branches     4001     3999    -2     
=======================================
  Hits        25111    25111           
  Misses      29607    29607           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 512eeb5
packages 40.34% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.15 KB (-0.04% 🔽) 883 ms (-0.04% 🔽) 557 ms (-13.45% 🔽) 1.5 s
thirdweb (cjs) 104.69 KB (0%) 2.1 s (0%) 946 ms (-10.1% 🔽) 3.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 120 ms (+241.36% 🔺) 234 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 7 ms (-74.98% 🔽) 17 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 131 ms (+76.57% 🔺) 507 ms

@MananTank MananTank requested a review from jnsdls November 12, 2024 19:33
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring code related to code blocks in the UI by replacing the `CodeBlock` component with a new `CodeClient` component and introducing a `PlainTextCodeBlock` for plain text display. It also updates styles and dependencies.

### Detailed summary
- Removed `CodeBlock` component from various files.
- Introduced `CodeClient` component for enhanced code rendering.
- Added `PlainTextCodeBlock` for displaying plain text.
- Updated styles in `globals.css` for dark mode support.
- Added new utility functions for code formatting.
- Updated dependencies in `package.json` and `pnpm-lock.yaml`.

> The following files were skipped due to too many changes: `pnpm-lock.yaml`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants