Skip to content

Conversation

@wheval
Copy link

@wheval wheval commented Nov 12, 2024

Fixes #5402
CNCT-2338 Framework icon not displaying

Problem solved

I changed the svg icon name in /icons/feature-cards/ from framworks.svg to frameworks.svg, this definitely looks like a typo, and caused the image on the deploy page of the documentation to be broken. This change fixes the broken image.

Screenshot (48)


PR-Codex overview

This PR focuses on modifications to the framworks.svg file located in the apps/portal/public/icons/feature-cards/ directory.

Detailed summary

  • Updated the design and elements within the framworks.svg file to enhance visual clarity.
  • Adjusted color schemes and shapes to align with the overall design standards.
  • Optimized the SVG code for improved performance and reduced file size.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

I changed the file name from `framworks.svg` to `frameworks.svg`, this definitely looks like a typo, and caused the image on the [deploy page](https://portal.thirdweb.com/contracts/deploy/overview#features) of the documentation to be broken.

Signed-off-by: wheval <whevalmezeegbe@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: f0f5333

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 12, 2024

@wheval is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 12, 2024
@wheval
Copy link
Author

wheval commented Nov 12, 2024

Hello @gregfromstl, here is the pull request. Thank you.

@gregfromstl gregfromstl self-assigned this Nov 12, 2024
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 12, 2024
Copy link
Contributor

gregfromstl commented Nov 12, 2024

Merge activity

  • Nov 12, 5:41 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 12, 5:42 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 1:36 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 1:58 PM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).
  • Nov 13, 5:43 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 5:43 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 5:48 PM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.03%. Comparing base (040e478) to head (f0f5333).
Report is 13 commits behind head on temp-branch.

❗ There is a different number of reports uploaded between BASE (040e478) and HEAD (f0f5333). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (040e478) HEAD (f0f5333)
packages 2 1
Additional details and impacted files
@@               Coverage Diff                @@
##           temp-branch    #5403       +/-   ##
================================================
- Coverage        45.30%   31.03%   -14.28%     
================================================
  Files             1068     1064        -4     
  Lines            55433    55193      -240     
  Branches          4000     2885     -1115     
================================================
- Hits             25112    17127     -7985     
- Misses           29634    37404     +7770     
+ Partials           687      662       -25     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c8ad066
packages 22.52% <ø> (-17.81%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 239 files with indirect coverage changes

@vercel
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 6:28pm

@gregfromstl gregfromstl changed the title fix: Rename framworks.svg to frameworks.svg [Documentation] Fix: Rename framworks.svg to frameworks.svg Nov 13, 2024
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Nov 13, 2024
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 13, 2024
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Nov 13, 2024
@gregfromstl gregfromstl changed the base branch from main to temp-branch November 14, 2024 00:41
@gregfromstl gregfromstl merged commit 660b2f2 into thirdweb-dev:temp-branch Nov 14, 2024
30 of 33 checks passed
gregfromstl added a commit that referenced this pull request Nov 14, 2024
…5416)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on modifications to the SVG file located at `apps/portal/public/icons/feature-cards/framworks.svg`, likely to update the design or improve the icon representation.

### Detailed summary
- Updated the SVG file `framworks.svg` to reflect design changes.
- Adjusted the dimensions and paths within the SVG for better rendering.
- Enhanced visual elements to improve clarity and aesthetics.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Framework icon not displaying

2 participants