-
Notifications
You must be signed in to change notification settings - Fork 619
[Documentation] Fix: Rename framworks.svg to frameworks.svg #5403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Fix: Rename framworks.svg to frameworks.svg #5403
Conversation
I changed the file name from `framworks.svg` to `frameworks.svg`, this definitely looks like a typo, and caused the image on the [deploy page](https://portal.thirdweb.com/contracts/deploy/overview#features) of the documentation to be broken. Signed-off-by: wheval <whevalmezeegbe@gmail.com>
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
@wheval is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
|
Hello @gregfromstl, here is the pull request. Thank you. |
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## temp-branch #5403 +/- ##
================================================
- Coverage 45.30% 31.03% -14.28%
================================================
Files 1068 1064 -4
Lines 55433 55193 -240
Branches 4000 2885 -1115
================================================
- Hits 25112 17127 -7985
- Misses 29634 37404 +7770
+ Partials 687 662 -25
*This pull request uses carry forward flags. Click here to find out more. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…5416) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on modifications to the SVG file located at `apps/portal/public/icons/feature-cards/framworks.svg`, likely to update the design or improve the icon representation. ### Detailed summary - Updated the SVG file `framworks.svg` to reflect design changes. - Adjusted the dimensions and paths within the SVG for better rendering. - Enhanced visual elements to improve clarity and aesthetics. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Fixes #5402
CNCT-2338 Framework icon not displaying
Problem solved
I changed the svg icon name in
/icons/feature-cards/fromframworks.svgtoframeworks.svg, this definitely looks like a typo, and caused the image on the deploy page of the documentation to be broken. This change fixes the broken image.PR-Codex overview
This PR focuses on modifications to the
framworks.svgfile located in theapps/portal/public/icons/feature-cards/directory.Detailed summary
framworks.svgfile to enhance visual clarity.