Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 13, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the routing paths in the apps/dashboard/framer-rewrites.js file to include new endpoints and modify existing ones.

Detailed summary

  • Added a new route: "/nebula".
  • Updated the existing route from "/connect/sign-in" to "/connect/sign-in" (unchanged).
  • Updated the existing route from "/contracts/modular-contracts" to "/contracts/explore".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:46pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 13, 2024 10:46pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 13, 2024 10:46pm
wallet-ui ⬜️ Skipped (Inspect) Nov 13, 2024 10:46pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 20:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 20:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 20:55 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: f331f01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review November 13, 2024 20:55
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 13, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank changed the title Add /nebula framer rewrite Add /nebula framer rewrite in dashboard Nov 13, 2024
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (7bbe60f) to head (f331f01).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5414   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7bbe60f
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 346 ms (-27.46% 🔽) 1.3 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 1.4 s (+26.06% 🔺) 3.5 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 54 ms (+26.46% 🔺) 169 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 59 ms (+354.29% 🔺) 69 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 238 ms (+48.59% 🔺) 614 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 13, 2024
Copy link
Contributor

gregfromstl commented Nov 13, 2024

Merge activity

  • Nov 13, 5:42 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 5:42 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 5:48 PM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the routing paths in the `apps/dashboard/framer-rewrites.js` file by adding a new route and modifying existing ones.

### Detailed summary
- Added the route `"/nebula"`.
- Changed the `"/connect/sign-in"` route to `"/connect/sign-in"` (no change).
- Modified the `"/contracts/modular-contracts"` route.
- Modified the `"/contracts/explore"` route.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the 11-14-add__nebula_framer_rewrite branch from d7c1769 to f331f01 Compare November 13, 2024 22:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 22:43 Inactive
@graphite-app graphite-app bot merged commit f331f01 into main Nov 13, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 11-14-add__nebula_framer_rewrite branch November 13, 2024 22:48
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 13, 2024 22:48 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 13, 2024 22:48 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 13, 2024 22:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants