Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Nov 14, 2024

Updated Pay docs to clarify KYC in FAQs

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the page.mdx file in the apps/portal/src/app/connect/pay/faqs directory, clarifying the KYC (Know Your Customer) requirements for users purchasing with fiat currency.

Detailed summary

  • Changed the wording regarding KYC requirements for the Buy with Fiat feature.
  • Specified that KYC is required only for the first purchase and not for subsequent purchases on the same platform.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ❌ Failed (Inspect) Nov 15, 2024 11:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Nov 15, 2024 11:12pm
thirdweb-www ⬜️ Skipped (Inspect) Nov 15, 2024 11:12pm
wallet-ui ⬜️ Skipped (Inspect) Nov 15, 2024 11:12pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: acc7303

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 14, 2024
@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (304f2e6) to head (acc7303).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5425   +/-   ##
=======================================
  Coverage   45.50%   45.50%           
=======================================
  Files        1071     1071           
  Lines       55718    55718           
  Branches     4032     4032           
=======================================
  Hits        25357    25357           
  Misses      29674    29674           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 304f2e6
packages 40.61% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 437 ms (+6.75% 🔺) 1.4 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 816 ms (+10.18% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 30 ms (+15.56% 🔺) 144 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 13 ms (+43.02% 🔺) 23 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 75 ms (-29.52% 🔽) 451 ms

@gregfromstl gregfromstl changed the title Update Pay Docs [Portal] Docs: Update Pay Docs Nov 15, 2024
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 15, 2024
Copy link
Contributor

gregfromstl commented Nov 15, 2024

Merge activity

  • Nov 15, 6:07 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 15, 6:07 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 15, 6:12 PM EST: A user merged this pull request with the Graphite merge queue.

Updated Pay docs to clarify KYC in FAQs

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the content in the `page.mdx` file to clarify the KYC requirements for using the 'Buy with Fiat' feature in the `Pay` application.

### Detailed summary
- Revised explanation of KYC requirements for `Buy with Fiat`.
- Changed text to specify that KYC is required only for the first purchase, with no further requirements for subsequent purchases on the same platform.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the GiselleNessi-pay-docs branch from 040ea0e to acc7303 Compare November 15, 2024 23:09
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 15, 2024 23:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 23:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 23:09 Inactive
@graphite-app graphite-app bot merged commit acc7303 into main Nov 15, 2024
29 of 31 checks passed
@graphite-app graphite-app bot deleted the GiselleNessi-pay-docs branch November 15, 2024 23:12
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 15, 2024 23:12 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 15, 2024 23:12 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www November 15, 2024 23:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants