Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 14, 2024

CNCT-2370


PR-Codex overview

This PR focuses on enhancing the ConnectWalletSocialOptions.tsx file by adding a new property to the connection options for wallets.

Detailed summary

  • Added a new property chain to connectOptions, which takes its value from props.chain.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Nov 14, 2024

@vercel
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:39am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:39am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:39am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:39am

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: f7a4a46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 564 ms (+45.65% 🔺) 1.5 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 660 ms (-25.03% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 51 ms (+121.09% 🔺) 166 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 46 ms (+178.16% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 270 ms (+292.52% 🔺) 646 ms

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.51%. Comparing base (895b4d1) to head (f7a4a46).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5426      +/-   ##
==========================================
- Coverage   45.53%   45.51%   -0.03%     
==========================================
  Files        1070     1071       +1     
  Lines       55671    55700      +29     
  Branches     4032     4030       -2     
==========================================
+ Hits        25350    25351       +1     
- Misses      29633    29662      +29     
+ Partials      688      687       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 895b4d1
packages 40.61% <0.00%> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 6.91% <0.00%> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 15, 2024
Copy link
Contributor Author

gregfromstl commented Nov 15, 2024

Merge activity

  • Nov 14, 7:34 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 14, 7:34 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 14, 7:40 PM EST: A user merged this pull request with the Graphite merge queue.

CNCT-2370

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds support for the `chain` property in the `connectOptions` object within the `ConnectWalletSocialOptions.tsx` file, enhancing the flexibility of wallet connections based on the provided chain.

### Detailed summary
- Added `chain: props.chain` to the `connectOptions` object.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants