[Dashboard] Feature: Modules UI changes #5437

GWSzeto · 2024-11-15T20:19:51Z

https://linear.app/thirdweb/issue/DASH-469/small-changes-for-modules-ui

PR-Codex overview

This PR primarily focuses on enhancing the Transferable, Claimable, and Royalty components by adding new features, improving user interfaces, and correcting data handling related to ERC20 and ERC721 tokens.

Detailed summary

Added support for isErc20 state in Claimable and Royalty components.
Updated UI to conditionally render messages based on token type.
Introduced SequentialTokenIdFieldset for handling token ID inputs.
Changed bps to percentage in Royalty calculations and UI.
Improved input handling and validation for royalty percentage fields.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-11-15T20:19:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 11:12pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 11:12pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 11:12pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	⬜️ Skipped (Inspect)			Nov 25, 2024 11:12pm

changeset-bot · 2024-11-15T20:19:55Z

⚠️ No Changeset found

Latest commit: a98550d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-11-15T20:19:57Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

...oard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Royalty.tsx

codecov · 2024-11-15T20:21:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.84%. Comparing base (0e98b09) to head (a98550d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5437   +/-   ##
=======================================
  Coverage   43.84%   43.84%           
=======================================
  Files        1081     1081           
  Lines       56186    56186           
  Branches     3929     3929           
=======================================
  Hits        24635    24635           
  Misses      30868    30868           
  Partials      683      683

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 0e98b09
packages	`38.60% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-11-15T20:23:45Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	44.97 KB (0%)	900 ms (0%)	3.1 s (+23.63% 🔺)	4 s
thirdweb (cjs)	105.01 KB (0%)	2.2 s (0%)	4.1 s (-24.65% 🔽)	6.2 s
thirdweb (minimal + tree-shaking)	5.6 KB (0%)	113 ms (0%)	227 ms (+39.37% 🔺)	339 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	209 ms (+464.84% 🔺)	219 ms
thirdweb/react (minimal + tree-shaking)	18.38 KB (0%)	368 ms (0%)	440 ms (+51.82% 🔺)	808 ms

gregfromstl · 2024-11-15T22:57:08Z

Linear ticket please

...nents/contract-components/contract-deploy-form/modular-contract-default-modules-fieldset.tsx

...ard/src/components/contract-components/contract-deploy-form/sequential-token-id-fieldset.tsx

...oard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Royalty.tsx

graphite-app · 2024-11-25T19:19:47Z

...oard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Royalty.tsx

+  percentage: z
    .string()
-    .min(1, { message: "Invalid BPS" })
-    .refine((v) => Number(v) >= 0, { message: "Invalid BPS" }),
+    .min(1, { message: "Invalid percentage" })
+    .refine((v) => Number(v) === 0 || (Number(v) >= 0.01 && Number(v) <= 100), {
+      message: "Invalid percentage",
+    }),


There appears to be conflicting validation logic for zero values. The min(1) string validation will reject "0" inputs, while the refine() check explicitly allows zero values with Number(v) === 0. To consistently support zero values, the min(1) validation should be removed, leaving only the refine() check to handle the full range of valid inputs (0 and 0.01-100).

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

MananTank · 2024-11-25T21:27:25Z

...ard/src/components/contract-components/contract-deploy-form/sequential-token-id-fieldset.tsx

+
+        <FormErrorMessage>{props.errorMessage}</FormErrorMessage>
+
+        <FormHelperText className="!text-sm text-muted-foreground">


If you are using FormFieldSetup -
you can remove FormLabel, FormErrorMessage and FormHelperText and just pass those to props label , errorMessage, helperText etc to avoid adding chakra components

graphite-app · 2024-11-25T23:06:22Z

Merge activity

Nov 25, 6:06 PM EST: A user added this pull request to the Graphite merge queue.
Nov 25, 6:12 PM EST: A user merged this pull request with the Graphite merge queue.

https://linear.app/thirdweb/issue/DASH-469/small-changes-for-modules-ui  --- ## PR-Codex overview This PR focuses on enhancing the functionality and user experience of the `Transferable`, `Claimable`, and `Royalty` components in the dashboard application, particularly by adding support for ERC20 tokens and improving form handling for royalties. ### Detailed summary - Added support for `isErc20` state in `Transferable` and `Claimable` components. - Updated UI to display messages related to transfer restrictions and accounts. - Introduced `SequentialTokenIdFieldset` to handle token ID inputs. - Changed royalty handling from BPS to percentage in `Royalty` component. - Improved form validation and error messaging for royalty inputs. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

GWSzeto requested review from MananTank, jnsdls and joaquim-verges as code owners November 15, 2024 20:19

github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 15, 2024

graphite-app bot reviewed Nov 15, 2024

View reviewed changes

...oard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Royalty.tsx Outdated Show resolved Hide resolved

GWSzeto force-pushed the modules-ui-changes branch from f57f876 to cf98aa5 Compare November 15, 2024 20:28

vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 20:28 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 20:28 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 20:28 Inactive

vercel bot had a problem deploying to Preview – thirdweb-www November 15, 2024 20:36 Failure

gregfromstl changed the title ~~Modules UI changes~~ [Dashboard]: Feature: Modules UI changes Nov 15, 2024

gregfromstl changed the title ~~[Dashboard]: Feature: Modules UI changes~~ [Dashboard] Feature: Modules UI changes Nov 15, 2024

gregfromstl assigned GWSzeto Nov 15, 2024

vercel bot deployed to Preview – thirdweb_playground November 16, 2024 02:29 View deployment

vercel bot deployed to Preview – docs-v2 November 16, 2024 02:30 View deployment

vercel bot deployed to Preview – wallet-ui November 16, 2024 02:30 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www November 16, 2024 02:35 Failure

GWSzeto force-pushed the modules-ui-changes branch from a40de04 to 407880a Compare November 19, 2024 18:04

vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 18:05 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 18:05 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 18:05 Inactive

graphite-app bot reviewed Nov 19, 2024

View reviewed changes

...nents/contract-components/contract-deploy-form/modular-contract-default-modules-fieldset.tsx Show resolved Hide resolved

vercel bot deployed to Preview – wallet-ui November 19, 2024 18:06 View deployment

vercel bot deployed to Preview – thirdweb_playground November 19, 2024 18:07 View deployment

vercel bot deployed to Preview – docs-v2 November 19, 2024 18:07 View deployment

vercel bot deployed to Preview – thirdweb-www November 19, 2024 18:20 View deployment

MananTank requested changes Nov 20, 2024

View reviewed changes

graphite-app bot reviewed Nov 25, 2024

View reviewed changes

vercel bot deployed to Preview – wallet-ui November 25, 2024 19:19 View deployment

vercel bot deployed to Preview – thirdweb_playground November 25, 2024 19:20 View deployment

vercel bot deployed to Preview – docs-v2 November 25, 2024 19:20 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www November 25, 2024 19:28 Failure

MananTank reviewed Nov 25, 2024

View reviewed changes

vercel bot temporarily deployed to Preview – thirdweb_playground November 25, 2024 22:07 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 25, 2024 22:07 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 25, 2024 22:07 Inactive

MananTank approved these changes Nov 25, 2024

View reviewed changes

vercel bot deployed to Preview – thirdweb-www November 25, 2024 22:19 View deployment

GWSzeto added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 25, 2024

github-actions bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Nov 25, 2024

MananTank force-pushed the modules-ui-changes branch from e83056b to a98550d Compare November 25, 2024 23:07

vercel bot temporarily deployed to Preview – wallet-ui November 25, 2024 23:07 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 25, 2024 23:07 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 25, 2024 23:07 Inactive

vercel bot deployed to Preview – thirdweb-www November 25, 2024 23:12 View deployment

graphite-app bot merged commit a98550d into main Nov 25, 2024
32 checks passed

graphite-app bot deleted the modules-ui-changes branch November 25, 2024 23:12

vercel bot temporarily deployed to Production – thirdweb_playground November 25, 2024 23:12 Inactive

vercel bot temporarily deployed to Production – wallet-ui November 25, 2024 23:12 Inactive

vercel bot temporarily deployed to Production – docs-v2 November 25, 2024 23:12 Inactive

vercel bot deployed to Production – thirdweb-www November 25, 2024 23:21 View deployment


		<FormErrorMessage>{props.errorMessage}</FormErrorMessage>

		<FormHelperText className="!text-sm text-muted-foreground">

[Dashboard] Feature: Modules UI changes #5437

[Dashboard] Feature: Modules UI changes #5437

Uh oh!

Conversation

GWSzeto commented Nov 15, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

Uh oh!

codecov bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

gregfromstl commented Nov 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

MananTank Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GWSzeto commented Nov 15, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 15, 2024 •

edited

Loading

changeset-bot bot commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024 •

edited

Loading

graphite-app bot commented Nov 25, 2024 •

edited

Loading