Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Nov 18, 2024

PR-Codex overview

This PR focuses on updating the documentation for the Thirdweb .NET SDK, enhancing method descriptions, and modifying the sidebar links for wallet actions. It also removes some outdated pages and adds new methods for wallet interactions.

Detailed summary

  • Deleted getemail and getphonenumber action pages.
  • Updated the link for ThirdwebExtensions reference.
  • Added documentation for EcosystemWallet.GetEcosystemDetails and EcosystemWallet.GetUserDetails.
  • Modified sidebar links:
    • Renamed GetEmail to GetUserDetails.
    • Added GetEcosystemDetails.
    • Renamed GetPhoneNumber to GenerateExternalLoginLink.
  • Added documentation for EcosystemWallet.GenerateExternalLoginLink.
  • Updated Transfer method description to include ERC20 tokens.
  • Revised wallet connection methods in the ThirdwebManager documentation, including renaming and reordering.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 565dbb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:16pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Nov 18, 2024 7:16pm
thirdweb-www ⬜️ Skipped (Inspect) Nov 18, 2024 7:16pm
wallet-ui ⬜️ Skipped (Inspect) Nov 18, 2024 7:16pm

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 18, 2024
@0xFirekeeper 0xFirekeeper added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 18, 2024
Copy link
Member Author

0xFirekeeper commented Nov 18, 2024

Merge activity

  • Nov 18, 11:14 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 18, 2:10 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 18, 2:13 PM EST: A user merged this pull request with the Graphite merge queue.

@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (f01de73) to head (565dbb9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5445   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55707    55707           
  Branches     4031     4031           
=======================================
  Hits        25360    25360           
  Misses      29660    29660           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f01de73
packages 40.63% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.13 KB (0%) 903 ms (0%) 3.1 s (-4.15% 🔽) 4 s
thirdweb (cjs) 105.15 KB (0%) 2.2 s (0%) 6.5 s (+28.53% 🔺) 8.6 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 156 ms (-42.88% 🔽) 271 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 103 ms (+169.2% 🔺) 113 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 971 ms (+149.59% 🔺) 1.4 s

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on updating the documentation for the `Thirdweb .NET SDK`, adding new methods, modifying existing ones, and improving sidebar navigation. It also removes outdated pages and refines descriptions for better clarity.

### Detailed summary
- Deleted `getemail` and `getphonenumber` action pages.
- Updated the reference link for `ThirdwebExtensions`.
- Added documentation for `EcosystemWallet.GetEcosystemDetails` and `EcosystemWallet.GetUserDetails`.
- Modified sidebar links, replacing `GetEmail` and `GetPhoneNumber` with `GetUserDetails` and `GenerateExternalLoginLink`.
- Added documentation for `EcosystemWallet.GenerateExternalLoginLink`.
- Updated `IThirdwebWallet.Transfer` method description and usage examples.
- Revised wallet connection methods in `ThirdwebManager`, updating method names and descriptions.
- Improved `Child Prefabs` section, renaming and clarifying modal usage.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@0xFirekeeper 0xFirekeeper force-pushed the firekeeper/unity-5.9-docs branch from b00fb9e to 565dbb9 Compare November 18, 2024 19:10
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 18, 2024 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 18, 2024 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 18, 2024 19:11 Inactive
@graphite-app graphite-app bot merged commit 565dbb9 into main Nov 18, 2024
29 of 31 checks passed
@graphite-app graphite-app bot deleted the firekeeper/unity-5.9-docs branch November 18, 2024 19:13
@vercel vercel bot temporarily deployed to Production – thirdweb-www November 18, 2024 19:13 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 18, 2024 19:13 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 18, 2024 19:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants