Skip to content

Conversation

@alecananian
Copy link
Contributor

@alecananian alecananian commented Nov 18, 2024

Fixes link to 404 page on the Unity extensions docs


PR-Codex overview

This PR updates a hyperlink in the page.mdx file, directing users to a more specific documentation page for ThirdwebExtensions.

Detailed summary

  • Changed the link in page.mdx from https://thirdweb-dev.github.io/dotnet/index.html to https://thirdweb-dev.github.io/dotnet/docs/Thirdweb.ThirdwebExtensions.html for a complete list of available contract extensions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Signed-off-by: Alec Ananian <1013230+alecananian@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: c137d90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 18, 2024

@alecananian is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 18, 2024
@gregfromstl gregfromstl self-assigned this Nov 18, 2024
@vercel
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:27pm

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 18, 2024
Copy link
Contributor

gregfromstl commented Nov 18, 2024

Merge activity

  • Nov 18, 2:09 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 18, 2:27 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 18, 3:02 PM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@gregfromstl gregfromstl changed the title docs: fix link to ThirdwebExtensions full reference [Portal] Fix: link to ThirdwebExtensions full reference Nov 18, 2024
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.37%. Comparing base (565dbb9) to head (b291695).
Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (565dbb9) and HEAD (b291695). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (565dbb9) HEAD (b291695)
packages 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5446       +/-   ##
===========================================
- Coverage   45.52%   31.37%   -14.16%     
===========================================
  Files        1070     1066        -4     
  Lines       55707    55467      -240     
  Branches     4031     2923     -1108     
===========================================
- Hits        25360    17400     -7960     
- Misses      29660    37402     +7742     
+ Partials      687      665       -22     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f01de73
packages 22.99% <ø> (-17.64%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 238 files with indirect coverage changes

---- 🚨 Try these New Features:

Signed-off-by: greg <gregfromstl@gmail.com>
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Nov 18, 2024
@joaquim-verges joaquim-verges merged commit 1554e37 into thirdweb-dev:main Nov 18, 2024
27 of 31 checks passed
@alecananian alecananian deleted the patch-1 branch November 18, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants