Skip to content

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented Nov 19, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new structure for the modular contracts in the explore/pre-built-modular directory, enhancing the sidebar navigation and providing detailed documentation for various contract types like NFT Drop, Token Drop, Edition Drop, and more.

Detailed summary

  • Updated sidebar to include Pre-built Modular section with links to various modular contracts.
  • Added detailed documentation for:
    • NFT Drop
    • Token Drop
    • Edition Drop
    • Open Edition
    • NFT Collection
  • Included images and step-by-step guides for deploying each contract type.
  • Introduced claim conditions and modular features for different contract types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 3253a53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:47am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Nov 20, 2024 1:47am
thirdweb-www ⬜️ Skipped (Inspect) Nov 20, 2024 1:47am
wallet-ui ⬜️ Skipped (Inspect) Nov 20, 2024 1:47am

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 19, 2024
@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.81%. Comparing base (0e5d120) to head (3253a53).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5467   +/-   ##
=======================================
  Coverage   43.81%   43.81%           
=======================================
  Files        1069     1069           
  Lines       55726    55726           
  Branches     3882     3882           
=======================================
  Hits        24415    24415           
  Misses      30628    30628           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0e5d120
packages 38.50% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 2.7 s (-21.2% 🔽) 3.6 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 6.9 s (+32.18% 🔺) 9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 266 ms (-35.25% 🔽) 378 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 68 ms (+89.64% 🔺) 78 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 680 ms (+54.33% 🔺) 1.1 s

@saminacodes
Copy link
Member Author

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 01:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 20, 2024 01:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 01:15 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 20, 2024
Copy link
Contributor

gregfromstl commented Nov 20, 2024

Merge activity

  • Nov 19, 8:36 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 19, 8:36 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 19, 8:39 PM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on restructuring and enhancing the documentation for various modular contract types in the `pre-built-modular` section, including updates to navigation, descriptions, and deployment steps.

### Detailed summary
- Renamed `Pre-built Contracts` to `Pre-built Modular` in the sidebar.
- Added detailed documentation for:
  - `NFT Drop`
  - `Token`
  - `Token Drop`
  - `Edition Drop`
  - `Open Edition`
  - `Edition`
  - `NFT Collection`
- Included images and steps for deploying each contract type.
- Updated links and metadata for better navigation and user experience.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
https://linear.app/thirdweb/issue/DEVX-1828/7-guides-for-contracts
<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 20, 2024 01:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 01:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 01:37 Inactive
@graphite-app graphite-app bot merged commit 3253a53 into main Nov 20, 2024
29 of 31 checks passed
@graphite-app graphite-app bot deleted the contract-guides branch November 20, 2024 01:39
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 20, 2024 01:39 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 20, 2024 01:39 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www November 20, 2024 01:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants