Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 20, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the Token components across multiple screens to utilize the new TokenProvider, enhancing the management of token-related data and improving the overall structure of the code.

Detailed summary

  • Added TokenProvider to BuyTxHistoryButton, ViewTokens, BuyScreen, SendFunds, and SwapScreenContent.
  • Updated token-related components to use TokenName, AccountBalance, and TokenSymbol.
  • Improved layout and styling for better UI consistency.
  • Removed unused hooks and variables related to wallet balance management.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:21am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:21am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:21am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:21am

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 4e32a22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Nov 20, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kien-ngo kien-ngo changed the title update [SDK] Replace internal code with headless UI (1) Nov 20, 2024
@kien-ngo kien-ngo marked this pull request as ready for review November 20, 2024 16:58
@kien-ngo kien-ngo force-pushed the kien/replace-our-code-with-headless-ui branch from 6ad9d3d to 6613a1e Compare November 20, 2024 17:06
@kien-ngo kien-ngo force-pushed the kien/replace-our-code-with-headless-ui branch from 6613a1e to d0a0330 Compare November 20, 2024 17:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 827 ms (+55.24% 🔺) 1.8 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 1.2 s (+9.23% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 142 ms (+438.89% 🔺) 254 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 34 ms (+268.87% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 175 ms (+140.72% 🔺) 542 ms

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 257 lines in your changes missing coverage. Please review.

Project coverage is 43.73%. Comparing base (7973d64) to head (4e32a22).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...c/react/web/ui/ConnectWallet/screens/SendFunds.tsx 0.00% 114 Missing ⚠️
...creens/Buy/pay-transactions/BuyTxHistoryButton.tsx 0.00% 59 Missing ⚠️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.00% 54 Missing ⚠️
.../react/web/ui/ConnectWallet/screens/ViewTokens.tsx 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5470      +/-   ##
==========================================
- Coverage   43.88%   43.73%   -0.15%     
==========================================
  Files        1075     1079       +4     
  Lines       55944    56157     +213     
  Branches     3910     3909       -1     
==========================================
+ Hits        24550    24561      +11     
- Misses      30711    30913     +202     
  Partials      683      683              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7973d64
packages 38.46% <0.00%> (-0.16%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../react/web/ui/ConnectWallet/screens/ViewTokens.tsx 3.29% <0.00%> (-0.20%) ⬇️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.08% <0.00%> (-0.01%) ⬇️
...creens/Buy/pay-transactions/BuyTxHistoryButton.tsx 4.08% <0.00%> (-0.32%) ⬇️
...c/react/web/ui/ConnectWallet/screens/SendFunds.tsx 3.07% <0.00%> (-0.13%) ⬇️

... and 6 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants