Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Nov 21, 2024

https://linear.app/thirdweb/issue/INFRA-401/update-multiple-engine-versions

image image

PR-Codex overview

This PR primarily refactors the handling of teamSlug across various components and introduces new functionalities related to deployment public configuration and version updates.

Detailed summary

  • Renamed team_slug to teamSlug in multiple components.
  • Added useEngineGetDeploymentPublicConfiguration hook for fetching deployment config.
  • Updated EngineVersionBadge and ChangeVersionModal to accommodate new version update logic and alerts.
  • Modified the update process to include team-specific deployment paths.
  • Enhanced user interface with alerts and new selection options for version updates.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 21, 2024
@vercel
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:44am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:44am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:44am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:44am

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 88bceb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.84%. Comparing base (d1845f3) to head (88bceb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5479   +/-   ##
=======================================
  Coverage   43.84%   43.84%           
=======================================
  Files        1081     1081           
  Lines       56186    56186           
  Branches     3929     3929           
=======================================
  Hits        24635    24635           
  Misses      30868    30868           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 689fd31
packages 38.60% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 2.6 s (+29.54% 🔺) 3.5 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 5.6 s (+3.78% 🔺) 7.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 244 ms (+92.23% 🔺) 356 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 32 ms (-68.53% 🔽) 42 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 527 ms (+29.1% 🔺) 895 ms

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 05:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 05:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 05:33 Inactive
@arcoraven arcoraven changed the title WIP: Select Engine versions, fix team routes feat: Select Engine versions Nov 22, 2024
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 05:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 05:44 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 05:44 Inactive
@arcoraven arcoraven removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 22, 2024
Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comments

Copy link
Contributor Author

arcoraven commented Nov 25, 2024

Merge activity

  • Nov 25, 7:53 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 25, 7:53 AM EST: A user added this pull request to the Graphite merge queue.

@arcoraven arcoraven merged commit 46c3abb into main Nov 25, 2024
31 of 32 checks passed
@arcoraven arcoraven deleted the ph/teamsEngineRoutes branch November 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants