Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 21, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on restructuring the onboarding-related components and their imports, moving them into a new onboarding directory. It also updates references to these components in various files and modifies some import paths.

Detailed summary

  • Deleted apps/dashboard/src/components/onboarding/types.ts.
  • Moved Title.tsx, LinkWallet.tsx, ChoosePlan.tsx, General.tsx, ConfirmEmail.tsx, and useSkipOnboarding.tsx to apps/dashboard/src/app/login/onboarding/.
  • Updated import paths for isOnboardingComplete.
  • Changed imports for PricingCard from components/homepage/sections/PricingCard to @/components/blocks/pricing-card.
  • Added FeatureItem component in PricingCard.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: f0c077c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 21, 2024 13:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 21, 2024 13:33 Inactive
@vercel
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:02am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 22, 2024 8:02am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 22, 2024 8:02am
wallet-ui ⬜️ Skipped (Inspect) Nov 22, 2024 8:02am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 21, 2024 13:33 Inactive
@MananTank MananTank marked this pull request as ready for review November 21, 2024 13:33
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 21, 2024
Copy link
Member Author

MananTank commented Nov 21, 2024

@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.86%. Comparing base (6e6d907) to head (f0c077c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5481   +/-   ##
=======================================
  Coverage   43.86%   43.86%           
=======================================
  Files        1076     1076           
  Lines       55972    55972           
  Branches     3910     3910           
=======================================
  Hits        24551    24551           
  Misses      30738    30738           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e9ea476
packages 38.59% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 672 ms (+71.1% 🔺) 1.6 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 981 ms (-16.37% 🔽) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 106 ms (+24.86% 🔺) 218 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (+305.83% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 133 ms (+72.55% 🔺) 501 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR reorganizes the onboarding-related components and types in the `apps/dashboard/src/app/login/onboarding` directory, improving the structure and imports. It also updates several import paths and refactors components for better clarity.

### Detailed summary
- Moved onboarding-related files to `apps/dashboard/src/app/login/onboarding`.
- Updated import paths for `isOnboardingComplete` to reflect the new structure.
- Refactored `PricingCard` import in `AccountForm.tsx` and `ChoosePlan.tsx`.
- Added `FeatureItem` component in `PricingCard`.
- Updated `useSkipOnboarding` and `ConfirmEmail` for new import paths.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 11-21-onboarding_ui_adjustments_use_dologout_server_action_instead_of_fetch branch from 843f2a1 to 6e6d907 Compare November 22, 2024 07:49
@jnsdls jnsdls force-pushed the 11-21-move_onboarding_components_to_app_router_folder branch from 596b374 to f0c077c Compare November 22, 2024 07:50
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 07:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 07:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 07:50 Inactive
Base automatically changed from 11-21-onboarding_ui_adjustments_use_dologout_server_action_instead_of_fetch to main November 22, 2024 07:59
@graphite-app graphite-app bot merged commit f0c077c into main Nov 22, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 11-21-move_onboarding_components_to_app_router_folder branch November 22, 2024 08:02
@vercel vercel bot temporarily deployed to Production – wallet-ui November 22, 2024 08:03 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 22, 2024 08:03 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 22, 2024 08:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants