[Portal] Fix reference page static generation #5484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
MananTank
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
github-actions
bot
added
the
Portal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5484 +/- ##
=======================================
Coverage 43.86% 43.86%
=======================================
Files 1076 1076
Lines 55972 55972
Branches 3910 3910
=======================================
Hits 24551 24551
Misses 30738 30738
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
size-limit report 📦
|
jnsdls
previously approved these changes
Nov 21, 2024
MananTank
force-pushed
the
11-22-_portal_fix_reference_page_static_generation
branch
from
c446bec to
fe841a1
Compare
joaquim-verges
force-pushed
the
11-22-_portal_fix_reference_page_static_generation
branch
from
fe841a1 to
87dbd40
Compare
joaquim-verges
approved these changes
Nov 22, 2024
Contributor
Merge activity
|
NOTE:
This will not build - Recently the sidebar categories have been updated in the reference pages and this is creating issues with static build. Need to fix those errors
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on making adjustments to various files, including changing limits on data retrieval, modifying the structure of TypeScript types, and cleaning up the formatting of documentation.
### Detailed summary
- Changed `-limit` from `50` to `20` in `apps/portal/src/app/changelog/ghost.ts`.
- Removed `classes`, `variables`, `types`, and `enums` from `subgroups` in `apps/portal/src/app/references/components/TDoc/utils/subgroups.ts`.
- Cleaned up documentation text in `apps/portal/src/app/typescript/v5/chain/page.mdx`.
- Reformatted `PageProps` type definition in `apps/portal/src/app/references/components/TDoc/PageLayout.tsx` for better readability.
- Updated return type of `generateStaticParams` function to be more explicit in `apps/portal/src/app/references/components/TDoc/PageLayout.tsx`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
11-22-_portal_fix_reference_page_static_generation
branch
from
87dbd40 to
c02104d
Compare
graphite-app
bot
deleted the
11-22-_portal_fix_reference_page_static_generation
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
This will not build - Recently the sidebar categories have been updated in the reference pages and this is creating issues with static build. Need to fix those errors
PR-Codex overview
This PR focuses on optimizing various configurations and improving type definitions across multiple files in the project. Key adjustments include limiting results, modifying subgroup definitions, and refining TypeScript types for better clarity and structure.
Detailed summary
limitfrom50to20inghost.ts.classes,variables,types, andenumsfrom subgroup definitions insubgroups.ts.page.mdxto remove markdown formatting.PagePropstype definition inPageLayout.tsx.generateStaticParamsfor clarity.