Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 21, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the NebulaWaitListPageUI and its related components by adding a teamId prop to facilitate sharing invite links and improving the user experience.

Detailed summary

  • Updated Story to pass teamId="foo" to NebulaWaitListPageUI.
  • Modified NebulaWaitListPageUI to accept teamId prop.
  • Enhanced ShareButton to accept teamId and generate a personalized invite link.
  • Updated footer in NebulaWaitListPageUI to include the ShareButton and an invitation message.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 64d997e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 11:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 21, 2024 11:45pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 21, 2024 11:45pm
wallet-ui ⬜️ Skipped (Inspect) Nov 21, 2024 11:45pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 21, 2024 22:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 21, 2024 22:49 Inactive
@MananTank MananTank marked this pull request as ready for review November 21, 2024 22:49
@MananTank MananTank requested a review from jnsdls as a code owner November 21, 2024 22:49
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 21, 2024 22:49 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 21, 2024
Copy link
Member Author

MananTank commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.86%. Comparing base (d665684) to head (63c5277).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5485   +/-   ##
=======================================
  Coverage   43.86%   43.86%           
=======================================
  Files        1076     1076           
  Lines       55972    55972           
  Branches     3910     3910           
=======================================
  Hits        24551    24551           
  Misses      30738    30738           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d665684
packages 38.59% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 2.7 s (+11.58% 🔺) 3.6 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 6 s (+11.93% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 531 ms (+254.37% 🔺) 643 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 208 ms (+25.51% 🔺) 218 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 893 ms (+155.95% 🔺) 1.3 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 21, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `NebulaWaitListPageUI` and related components by adding a `teamId` prop to improve link sharing functionality. It modifies how the invite link is generated and displayed, allowing users to share a personalized link tied to their team.

### Detailed summary
- Updated `Story` to pass `teamId="foo"` to `NebulaWaitListPageUI`.
- Modified `NebulaWaitListPageUI` to accept `teamId` as a prop.
- Enhanced `ShareButton` to accept `teamId` and generate a personalized invite link.
- Changed tooltip label for the share button to "Copy Invite Link".
- Updated footer in `NebulaWaitListPageUI` to include the personalized `ShareButton` and a message encouraging sharing.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 11-22-update_nebula_waitlist_page_ui_and_invite_link branch from 64d997e to 63c5277 Compare November 21, 2024 23:40
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 21, 2024 23:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 21, 2024 23:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 21, 2024 23:41 Inactive
@graphite-app graphite-app bot merged commit 63c5277 into main Nov 21, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 11-22-update_nebula_waitlist_page_ui_and_invite_link branch November 21, 2024 23:45
@vercel vercel bot temporarily deployed to Production – wallet-ui November 21, 2024 23:45 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 21, 2024 23:45 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 21, 2024 23:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants