[Dashboard] Feature: Integrate ecosystem creation with Stripe billing #5488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jnsdls
force-pushed
the
_Dashboard_Feature_Integrate_ecosystem_creation_with_Stripe_billing
branch
from
25cc194 to
a7d70bf
Compare
jnsdls
force-pushed
the
_Dashboard_Feature_Integrate_ecosystem_creation_with_Stripe_billing
branch
from
a7d70bf to
d9d657e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5488 +/- ##
=======================================
Coverage 43.86% 43.86%
=======================================
Files 1076 1076
Lines 55972 55972
Branches 3910 3910
=======================================
Hits 24551 24551
Misses 30738 30738
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
jnsdls
force-pushed
the
_Dashboard_Feature_Integrate_ecosystem_creation_with_Stripe_billing
branch
from
d9d657e to
bb03c1d
Compare
jnsdls
added
the
DO NOT MERGE
Graphite App
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
...eam/[team_slug]/(team)/~/ecosystem/create/components/client/create-ecosystem-form.client.tsx
Outdated
Show resolved
Hide resolved
Contributor
size-limit report 📦
|
jnsdls
force-pushed
the
_Dashboard_Feature_Integrate_ecosystem_creation_with_Stripe_billing
branch
from
bb03c1d to
56ba315
Compare
jnsdls
removed
the
DO NOT MERGE
joaquim-verges
approved these changes
Nov 22, 2024
Contributor
Merge activity
|
…#5488) ### TL;DR Refactored ecosystem creation flow to use server actions and removed the confirmation dialog. ### What changed? - Created a new server action `createEcosystem` to handle ecosystem creation - Extracted `BASE_URL` constant for reusability - Removed the confirmation dialog from the creation form - Simplified form submission to directly create ecosystems - Added more specific error handling with user-friendly toast messages - Changed component props to use `teamSlug` instead of `ecosystemLayoutPath` ### How to test? 1. Navigate to the ecosystem creation page 2. Fill out the ecosystem form with a name and logo 3. Select permission type (PARTNER_WHITELIST or ANYONE) 4. Submit the form 5. Verify redirect to Stripe billing portal 6. Verify appropriate error messages display for various error scenarios ### Why make this change? To streamline the ecosystem creation process by implementing server-side actions and providing better error handling. This change improves the user experience by removing the extra confirmation step while maintaining secure server-side processing of ecosystem creation. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the `EcosystemCreatePage` and related components to streamline the creation of ecosystems, updating function signatures, and improving the handling of the creation process. ### Detailed summary - Removed `ecosystemLayoutPath` prop from `EcosystemCreatePage`. - Added `teamSlug` prop to `EcosystemCreatePage` and `CreateEcosystemForm`. - Updated `createEcosystem` function to handle authentication and API calls. - Enhanced error handling in the `CreateEcosystemForm`. - Removed unused imports and state management related to confirmation dialogs. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
_Dashboard_Feature_Integrate_ecosystem_creation_with_Stripe_billing
branch
from
56ba315 to
e9ea476
Compare
graphite-app
bot
deleted the
_Dashboard_Feature_Integrate_ecosystem_creation_with_Stripe_billing
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored ecosystem creation flow to use server actions and removed the confirmation dialog.
What changed?
createEcosystemto handle ecosystem creationBASE_URLconstant for reusabilityteamSluginstead ofecosystemLayoutPathHow to test?
Why make this change?
To streamline the ecosystem creation process by implementing server-side actions and providing better error handling. This change improves the user experience by removing the extra confirmation step while maintaining secure server-side processing of ecosystem creation.
PR-Codex overview
This PR focuses on refactoring the
EcosystemCreatePageand its related components to improve the handling of team-specific data when creating an ecosystem, including changes to form submission and URL management.Detailed summary
ecosystemLayoutPathprop fromEcosystemCreatePage.teamSlugprop inEcosystemCreatePageandCreateEcosystemForm.BASE_URLlogic inenv.ts.createEcosystemaction for better error handling and token management.CreateEcosystemForm.