-
Notifications
You must be signed in to change notification settings - Fork 619
feat: test webhook and delete wallet #5489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
...eam/[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/webhooks-table.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5489 +/- ##
=======================================
Coverage 43.84% 43.84%
=======================================
Files 1081 1081
Lines 56186 56186
Branches 3929 3929
=======================================
Hits 24635 24635
Misses 30868 30868
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
...am_slug]/(team)/~/engine/(instance)/[engineId]/overview/components/backend-wallets-table.tsx
Outdated
Show resolved
Hide resolved
...eam/[team_slug]/(team)/~/engine/(instance)/[engineId]/webhooks/components/webhooks-table.tsx
Outdated
Show resolved
Hide resolved
MananTank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address comments
| </div> | ||
| </ModalBody> | ||
| </ModalContent> | ||
| <ModalFooter /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ModalFooter component appears to be rendered outside its parent ModalContent, which breaks the expected component hierarchy. This can lead to styling and layout issues. Either move it inside ModalContent or remove it if not needed for this modal.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Merge activity
|
test webhook modal:

delete local wallet modal:

PR-Codex overview
This PR introduces new functionalities and refactors existing code in the
useEnginehooks related to backend wallets and webhooks. It adds deletion capabilities for backend wallets and webhooks, and introduces testing for webhooks, improving user interactions and error handling.Detailed summary
typefromstringtoEngineBackendWalletTypeinuseEngine.useEngineDeleteBackendWalletfor deleting backend wallets.useEngineRevokeWebhooktouseEngineDeleteWebhook.useEngineTestWebhookfor testing webhooks.DeleteModalfor backend wallet deletion with confirmation.