Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Nov 22, 2024

test webhook modal:
image

delete local wallet modal:
image


PR-Codex overview

This PR introduces new functionalities and refactors existing code in the useEngine hooks related to backend wallets and webhooks. It adds deletion capabilities for backend wallets and webhooks, and introduces testing for webhooks, improving user interactions and error handling.

Detailed summary

  • Changed type from string to EngineBackendWalletType in useEngine.
  • Added useEngineDeleteBackendWallet for deleting backend wallets.
  • Renamed useEngineRevokeWebhook to useEngineDeleteWebhook.
  • Added useEngineTestWebhook for testing webhooks.
  • Updated modal components for deleting webhooks and backend wallets.
  • Improved error handling and success notifications for delete operations.
  • Introduced DeleteModal for backend wallet deletion with confirmation.
  • Added UI components for testing webhooks and displaying results.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: a3bfdbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:05am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:05am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:05am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:05am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 22, 2024
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.84%. Comparing base (46ef3e6) to head (a3bfdbb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5489   +/-   ##
=======================================
  Coverage   43.84%   43.84%           
=======================================
  Files        1081     1081           
  Lines       56186    56186           
  Branches     3929     3929           
=======================================
  Hits        24635    24635           
  Misses      30868    30868           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 46ef3e6
packages 38.60% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 426 ms (+2.15% 🔺) 1.4 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 826 ms (-5.25% 🔽) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 116 ms (+204.24% 🔺) 228 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 7 ms (+2.79% 🔺) 17 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 187 ms (+267.62% 🔺) 555 ms

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comments

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 24, 2024 02:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 24, 2024 02:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 24, 2024 02:46 Inactive
</div>
</ModalBody>
</ModalContent>
<ModalFooter />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ModalFooter component appears to be rendered outside its parent ModalContent, which breaks the expected component hierarchy. This can lead to styling and layout issues. Either move it inside ModalContent or remove it if not needed for this modal.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor Author

Merge activity

  • Nov 25, 10:04 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@arcoraven arcoraven disabled auto-merge November 26, 2024 03:12
@arcoraven arcoraven merged commit 1ad6983 into main Nov 26, 2024
30 of 31 checks passed
@arcoraven arcoraven deleted the ph/testWebhook branch November 26, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants