Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 22, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the UploadStep component in the batch upload feature by replacing Heading and Link components with simpler HTML elements, enhancing readability and styling consistency.

Detailed summary

  • Replaced Heading components with <p> for text display.
  • Changed Link components to <a> elements for file downloads.
  • Updated class names to use Tailwind CSS for styling.
  • Adjusted text content for clarity and consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 2:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 22, 2024 2:12pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 22, 2024 2:12pm
wallet-ui ⬜️ Skipped (Inspect) Nov 22, 2024 2:12pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 10:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 10:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 10:01 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 24f4e5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kien-ngo kien-ngo marked this pull request as ready for review November 22, 2024 10:01
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 22, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.85%. Comparing base (b5baeae) to head (24f4e5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5491   +/-   ##
=======================================
  Coverage   43.85%   43.85%           
=======================================
  Files        1075     1075           
  Lines       55944    55944           
  Branches     3907     3907           
=======================================
  Hits        24534    24534           
  Misses      30727    30727           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b5baeae
packages 38.58% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 3.4 s (+29.63% 🔺) 4.3 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 5.7 s (+9.01% 🔺) 7.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 511 ms (+346.32% 🔺) 623 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 67 ms (+81.6% 🔺) 77 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 708 ms (-18.84% 🔽) 1.1 s

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

These two links at the bottom are not working

the ones on top are working:

image.png

@kien-ngo kien-ngo force-pushed the kien/fix-json-download-in-upload-step branch from e5dd67d to 057697b Compare November 22, 2024 13:59
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 13:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 13:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 13:59 Inactive
@kien-ngo kien-ngo requested a review from MananTank November 22, 2024 13:59
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the `UploadStep` component in `upload-step.tsx` to replace `Heading` and `Link` components with standard HTML elements like `p` and `a`, enhancing simplicity and readability.

### Detailed summary
- Replaced `Heading` components with `p` elements for text display.
- Changed `Link` components to `a` elements for file downloads.
- Updated class names for styling consistency.
- Simplified the conditional rendering structure.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/fix-json-download-in-upload-step branch from 057697b to 24f4e5a Compare November 22, 2024 14:09
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 14:09 Inactive
@graphite-app graphite-app bot merged commit 24f4e5a into main Nov 22, 2024
30 of 31 checks passed
@graphite-app graphite-app bot deleted the kien/fix-json-download-in-upload-step branch November 22, 2024 14:13
@vercel vercel bot temporarily deployed to Production – wallet-ui November 22, 2024 14:13 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 22, 2024 14:13 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 22, 2024 14:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants