-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Fix JSON donwload in upload-step.tsx #5491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5491 +/- ##
=======================================
Coverage 43.85% 43.85%
=======================================
Files 1075 1075
Lines 55944 55944
Branches 3907 3907
=======================================
Hits 24534 24534
Misses 30727 30727
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
size-limit report 📦
|
MananTank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e5dd67d to
057697b
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on refactoring the `UploadStep` component in `upload-step.tsx` to replace `Heading` and `Link` components with standard HTML elements like `p` and `a`, enhancing simplicity and readability.
### Detailed summary
- Replaced `Heading` components with `p` elements for text display.
- Changed `Link` components to `a` elements for file downloads.
- Updated class names for styling consistency.
- Simplified the conditional rendering structure.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
057697b to
24f4e5a
Compare



Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on updating the
UploadStepcomponent in the batch upload feature by replacingHeadingandLinkcomponents with simpler HTML elements, enhancing readability and styling consistency.Detailed summary
Headingcomponents with<p>for text display.Linkcomponents to<a>elements for file downloads.